Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA-277] Update date/time format to match datamanager #1504

Merged
merged 3 commits into from
Oct 26, 2022
Merged

[DATA-277] Update date/time format to match datamanager #1504

merged 3 commits into from
Oct 26, 2022

Conversation

JohnN193
Copy link
Member

@JohnN193 JohnN193 commented Oct 17, 2022 •
edited
Loading

SLAM PR for this viamrobotics/slam#73

updates to the slam repo to use the same timeformat used by other services. Will not merge until integration tests pass, which requires updates from the slam repo first

https://viam.atlassian.net/browse/DATA-277

@JohnN193 JohnN193 changed the title update time format [DATA-277] Update date/time format to match datamanager Oct 17, 2022
@JohnN193 JohnN193 marked this pull request as ready for review October 19, 2022 15:35
@JohnN193 JohnN193 mentioned this pull request Oct 19, 2022
Merged
kkufieta
kkufieta approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@kkufieta kkufieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a comment about removing the comment

services/slam/builtin/builtin.go Outdated
Comment on lines 58 to 60
// TODO change time format to .Format(time.RFC3339Nano) https://viam.atlassian.net/browse/DATA-277
// time format for the slam service.
slamTimeFormat = "2006-01-02T15_04_05.0000"
slamTimeFormat = time.RFC3339Nano
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment

tessavitabile
tessavitabile approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@tessavitabile tessavitabile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod nit

services/slam/builtin/builtin.go
@@ -57,7 +57,7 @@ const (
parsePortMaxTimeoutSec = 60
// TODO change time format to .Format(time.RFC3339Nano) https://viam.atlassian.net/browse/DATA-277
// time format for the slam service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Remove TODO. There are also a few other TODOs for DATA-277, so please make sure to remove them all.

@JohnN193 JohnN193 added the safe to test This pull request is marked safe to test from a trusted zone label Oct 26, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 26, 2022
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
go.viam.com/rdk/components/arm 59% ➖
go.viam.com/rdk/components/arm/universalrobots 12% ❌
go.viam.com/rdk/components/arm/xarm 2% ❌
go.viam.com/rdk/components/arm/yahboom 7% ❌
go.viam.com/rdk/components/audioinput 55% ➖
go.viam.com/rdk/components/base 68% ➖
go.viam.com/rdk/components/base/agilex 62% ➖
go.viam.com/rdk/components/base/boat 41% ❌
go.viam.com/rdk/components/base/wheeled 76% ✅
go.viam.com/rdk/components/board 69% ➖
go.viam.com/rdk/components/board/arduino 10% ❌
go.viam.com/rdk/components/board/commonsysfs 47% ❌
go.viam.com/rdk/components/board/fake 39% ❌
go.viam.com/rdk/components/board/numato 19% ❌
go.viam.com/rdk/components/board/pi 50% ➖
go.viam.com/rdk/components/camera 66% ➖
go.viam.com/rdk/components/camera/fake 67% ➖
go.viam.com/rdk/components/camera/ffmpeg 71% ✅
go.viam.com/rdk/components/camera/transformpipeline 80% ✅
go.viam.com/rdk/components/camera/videosource 55% ➖
go.viam.com/rdk/components/encoder/fake 77% ✅
go.viam.com/rdk/components/gantry 68% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% ✅
go.viam.com/rdk/components/generic 84% ✅
go.viam.com/rdk/components/gripper 82% ✅
go.viam.com/rdk/components/input 86% ✅
go.viam.com/rdk/components/input/gpio 83% ✅
go.viam.com/rdk/components/motor 82% ✅
go.viam.com/rdk/components/motor/dmc4000 69% ➖
go.viam.com/rdk/components/motor/fake 58% ➖
go.viam.com/rdk/components/motor/gpio 64% ➖
go.viam.com/rdk/components/motor/gpiostepper 56% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% ➖
go.viam.com/rdk/components/movementsensor 67% ➖
go.viam.com/rdk/components/movementsensor/cameramono 40% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% ❌
go.viam.com/rdk/components/posetracker 88% ✅
go.viam.com/rdk/components/sensor 88% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% ❌
go.viam.com/rdk/components/servo 77% ✅
go.viam.com/rdk/config 77% ✅
go.viam.com/rdk/control 57% ➖
go.viam.com/rdk/data 78% ✅
go.viam.com/rdk/grpc 25% ❌
go.viam.com/rdk/ml 67% ➖
go.viam.com/rdk/ml/inference 70% ✅
go.viam.com/rdk/motionplan 69% ➖
go.viam.com/rdk/operation 84% ✅
go.viam.com/rdk/pointcloud 71% ✅
go.viam.com/rdk/protoutils 62% ➖
go.viam.com/rdk/referenceframe 78% ✅
go.viam.com/rdk/registry 88% ✅
go.viam.com/rdk/resource 85% ✅
go.viam.com/rdk/rimage 78% ✅
go.viam.com/rdk/rimage/depthadapter 94% ✅
go.viam.com/rdk/rimage/transform 73% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% ➖
go.viam.com/rdk/robot 93% ✅
go.viam.com/rdk/robot/client 79% ✅
go.viam.com/rdk/robot/framesystem 68% ➖
go.viam.com/rdk/robot/impl 80% ✅
go.viam.com/rdk/robot/server 58% ➖
go.viam.com/rdk/robot/web 60% ➖
go.viam.com/rdk/robot/web/stream 87% ✅
go.viam.com/rdk/services/armremotecontrol 75% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 25% ❌
go.viam.com/rdk/services/baseremotecontrol 75% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 71% ✅
go.viam.com/rdk/services/datamanager 62% ➖
go.viam.com/rdk/services/datamanager/builtin 78% ✅
go.viam.com/rdk/services/datamanager/datacapture 34% ❌
go.viam.com/rdk/services/datamanager/datasync 70% ➖
go.viam.com/rdk/services/motion 68% ➖
go.viam.com/rdk/services/motion/builtin 89% ✅
go.viam.com/rdk/services/navigation 54% ➖
go.viam.com/rdk/services/sensors 78% ✅
go.viam.com/rdk/services/sensors/builtin 97% ✅
go.viam.com/rdk/services/shell 15% ❌
go.viam.com/rdk/services/slam 86% ✅
go.viam.com/rdk/services/slam/builtin 73% ✅
go.viam.com/rdk/services/vision 82% ✅
go.viam.com/rdk/services/vision/builtin 74% ✅
go.viam.com/rdk/spatialmath 85% ✅
go.viam.com/rdk/subtype 96% ✅
go.viam.com/rdk/utils 71% ✅
go.viam.com/rdk/vision 26% ❌
go.viam.com/rdk/vision/chess 80% ✅
go.viam.com/rdk/vision/delaunay 87% ✅
go.viam.com/rdk/vision/keypoints 92% ✅
go.viam.com/rdk/vision/objectdetection 82% ✅
go.viam.com/rdk/vision/odometry 60% ➖
go.viam.com/rdk/vision/odometry/cmd 0% ❌
go.viam.com/rdk/vision/segmentation 49% ❌
go.viam.com/rdk/web/server 26% ❌
Summary 66% (19050 / 28839) ➖

@JohnN193 JohnN193 merged commit de8a070 into viamrobotics:main Oct 26, 2022
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
@JohnN193 JohnN193 deleted the DATA-277-update-date-time-format-to-match-datamanager branch March 22, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tessavitabile tessavitabile tessavitabile approved these changes

@kkufieta kkufieta kkufieta approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnN193 @kkufieta @tessavitabile @viambot