RSDK-474 Save resource error when not started #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -554,7 +554,7 @@ func (r *localRobot) newResource(ctx context.Context, config config.Component) ( | |||
| } | |||
|
|
|||
| if err != nil { | |||
| return nil, errors.Errorf("error building resource %s/%s/%s: %s", config.Model, rName.Subtype, config.Name, err) | |||
There was a problem hiding this comment.
Do we really want to remove all the identifying descriptors here? I can imagine a case where these errors may be hard to debug especially if you have two components with same subtype and model.
There was a problem hiding this comment.
moved it to https://github.com/viamrobotics/rdk/pull/1514/files#diff-77fd7ff51c1b7804c67c4df0a9a672ea0e3842b4a54bbd8ef81af82ac95c4f22R368-R369 so all errors from that function gets the additional info
Kschappacher
approved these changes
Oct 24, 2022
npmenard
reviewed
Oct 24, 2022
robot/impl/resource_manager.go
Outdated
| @@ -514,7 +520,11 @@ func (manager *resourceManager) RemoteByName(name string) (robot.Robot, bool) { | |||
| if iface, ok := manager.resources.Node(rName); ok { | |||
| part, ok := iface.(robot.Robot) | |||
| if !ok { | |||
| manager.logger.Errorw("tried to access remote but its not a robot interface", "remote_name", name, "type", iface) | |||
| if ph, ok := iface.(*resourcePlaceholder); ok { | |||
| manager.logger.Errorw("failed to get remote", "remote", name, "err", ph.err) | |||
npmenard
reviewed
Oct 24, 2022
robot/impl/resource_manager.go
Outdated
| if ph, ok := iface.(*resourcePlaceholder); ok { | ||
| manager.logger.Errorw("failed to get remote", "remote", name, "err", ph.err) | ||
| } else { | ||
| manager.logger.Errorw("tried to access remote but its not a robot interface", "remote", name, "type", iface) |
There was a problem hiding this comment.
are we going to get the relevant Type info without using %T?
npmenard
reviewed
Oct 24, 2022
robot/impl/resource_manager.go
Outdated
| @@ -630,6 +641,7 @@ func (manager *resourceManager) wrapResource(name resource.Name, config interfac | |||
| wrapper = &resourcePlaceholder{ | |||
| real: part, | |||
| config: config, | |||
| err: errors.New("resource being initialized"), | |||
There was a problem hiding this comment.
nit: resource not initialized yet
npmenard
reviewed
Oct 24, 2022
robot/impl/resource_manager.go
Outdated
| @@ -564,6 +574,7 @@ func (manager *resourceManager) markChildrenForUpdate(ctx context.Context, rName | |||
| wrapper := &resourcePlaceholder{ | |||
| real: nil, | |||
| config: originalConfig, | |||
| err: errors.New("resource marked for update"), | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
saves the error to the wrapper, which is returned when we try to access that resource.
Also updated some errors and logging to always return resource name + model if applicable