Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-444] In the absence of encoder require max_rpm for gpio motor #1529

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[RSDK-444] In the absence of encoder require max_rpm for gpio motor #1529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions components/motor/gpio/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ func (config *Config) Validate(path string) ([]string, error) {
// If an encoder is present the max_rpm field is optional, in the absence of an encoder the field is required
if config.Encoder != "" {
deps = append(deps, config.Encoder)
} else if config.MaxRPM <= 0 {
return nil, vutils.NewConfigValidationFieldRequiredError(path, "max_rpm")
}
return deps, nil
}
Expand Down