RSDK-150 Clarify error message when remote goes down #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
commented
Oct 26, 2022
viambot
added
the
safe to test
maximpertsov
force-pushed
the
RSDK-150-error-message-when-remote-goes-down-should-be-more-clear
branch
from
f0dfeda to
79a1a5f
Compare
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-150-error-message-when-remote-goes-down-should-be-more-clear
branch
from
0840f1c to
81836c6
Compare
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-150-error-message-when-remote-goes-down-should-be-more-clear
branch
from
81836c6 to
bf58be0
Compare
viambot
added
safe to test
edaniels
suggested changes
Oct 31, 2022
robot/client/client.go
Outdated
| opts ...googlegrpc.CallOption, | ||
| ) error { | ||
| if needsConnectionCheck(method) { | ||
| rc.Logger().Debugw("checking remote connection", "method", method) |
There was a problem hiding this comment.
this is gonna spam us a lot; maybe remove after testing
There was a problem hiding this comment.
agreed - I am only going to keep the log for when we skip the method call
cheukt
requested changes
Oct 31, 2022
viambot
added
safe to test
list out exempt methods reduce logging use built-in io.ErrClosedPipe error check error string reduce logging comment on interceptor order
also add tests for stream interceptor disconnect
maximpertsov
force-pushed
the
RSDK-150-error-message-when-remote-goes-down-should-be-more-clear
branch
from
3dcc1cd to
2bf947e
Compare
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
cheukt
approved these changes
Nov 2, 2022
| if err == nil { | ||
| return false | ||
| } | ||
| return strings.Contains(err.Error(), io.ErrClosedPipe.Error()) |
There was a problem hiding this comment.
nit: should be able to do errors.Is instead of a straight string match
There was a problem hiding this comment.
sadly we need to do the string match since the pipe closed error we receive is constructed from status.Error method, so it's not actually the same error.
viambot
added
safe to test
|
maximpertsov
deleted the
RSDK-150-error-message-when-remote-goes-down-should-be-more-clear
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://viam.atlassian.net/browse/RSDK-150
TODO