Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-836: make gamepad and baseremotecontrol fields optional #1538

Merged
merged 1 commit into from
Oct 28, 2022
Merged

RSDK-836: make gamepad and baseremotecontrol fields optional #1538

merged 1 commit into from
Oct 28, 2022

Conversation

stevebriskin
Copy link
Member

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 28, 2022
Otterverse
Otterverse approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't write the baseremotecontrol service, so had to dig for a sec to confirm, but yeah, looks like all these are safe to make optional as fields.

@stevebriskin stevebriskin merged commit 1f5d6ee into viamrobotics:main Oct 28, 2022
@stevebriskin stevebriskin deleted the RSDK-836 branch October 28, 2022 19:53
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otterverse Otterverse Otterverse approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevebriskin @Otterverse @viambot