Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data-504] reduce test image resolutions #1540

Merged
merged 3 commits into from
Oct 31, 2022
Merged

[Data-504] reduce test image resolutions #1540

merged 3 commits into from
Oct 31, 2022

Conversation

bhaney
Copy link
Member

@bhaney bhaney commented Oct 31, 2022 •
edited
Loading

Only changes tests, should speed up tests times for some packages by reducing the image/pointcloud size.

@bhaney bhaney added the safe to test This pull request is marked safe to test from a trusted zone label Oct 31, 2022
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Oct 31, 2022
kharijarrett
kharijarrett approved these changes Oct 31, 2022
View reviewed changes
components/camera/videosource/server_test.go
Ppx: 494.95941428,
Ppy: 370.70529534,
Ppx: 49.495941428,
Ppy: 37.070529534,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as all the tests pass. I'm mostly worried about this one since the resolution decrease wasn't perfectly 10x and the PPx/PPy reduction was.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The projection doesn't have to be perfect for the test (if this would make the resulting pointcloud unaligned, that is OK - just wanted to make sure it didn't crash or anything).

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 59% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 12% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% 0.00% ➖
go.viam.com/rdk/components/base 68% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 76% 0.00% ✅
go.viam.com/rdk/components/board 69% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 47% 0.00% ❌
go.viam.com/rdk/components/board/fake 39% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 66% -0.27% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 72% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 80% +0.40% ✅
go.viam.com/rdk/components/camera/videosource 55% -0.48% ➖
go.viam.com/rdk/components/encoder/fake 77% 0.00% ✅
go.viam.com/rdk/components/gantry 68% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 84% 0.00% ✅
go.viam.com/rdk/components/gripper 82% 0.00% ✅
go.viam.com/rdk/components/input 86% 0.00% ✅
go.viam.com/rdk/components/input/gpio 83% 0.00% ✅
go.viam.com/rdk/components/motor 82% 0.00% ✅
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 58% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 63% +0.45% ➖
go.viam.com/rdk/components/motor/gpiostepper 56% -0.59% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 67% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 40% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 88% 0.00% ✅
go.viam.com/rdk/components/sensor 88% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% 0.00% ❌
go.viam.com/rdk/components/servo 77% 0.00% ✅
go.viam.com/rdk/config 77% +0.08% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/motionplan 71% +2.12% ✅
go.viam.com/rdk/operation 84% 0.00% ✅
go.viam.com/rdk/pointcloud 71% 0.00% ✅
go.viam.com/rdk/protoutils 62% 0.00% ➖
go.viam.com/rdk/referenceframe 78% 0.00% ✅
go.viam.com/rdk/registry 88% 0.00% ✅
go.viam.com/rdk/resource 85% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 93% 0.00% ✅
go.viam.com/rdk/robot/client 79% 0.00% ✅
go.viam.com/rdk/robot/framesystem 68% 0.00% ➖
go.viam.com/rdk/robot/impl 79% -0.24% ✅
go.viam.com/rdk/robot/server 58% 0.00% ➖
go.viam.com/rdk/robot/web 60% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 25% 0.00% ❌
go.viam.com/rdk/services/baseremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 71% 0.00% ✅
go.viam.com/rdk/services/datamanager 62% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 78% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 21% 0.00% ❌
go.viam.com/rdk/services/datamanager/datasync 72% 0.00% ✅
go.viam.com/rdk/services/motion 68% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 89% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 78% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 15% 0.00% ❌
go.viam.com/rdk/services/slam 86% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 73% 0.00% ✅
go.viam.com/rdk/services/vision 82% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/spatialmath 85% 0.00% ✅
go.viam.com/rdk/subtype 96% 0.00% ✅
go.viam.com/rdk/utils 71% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (19068 / 28835) +0.12% ➖

@bhaney bhaney merged commit 7c28e2b into viamrobotics:main Oct 31, 2022
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
@bhaney bhaney deleted the data-504-reduce-test-image-resolutions branch April 21, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kharijarrett kharijarrett kharijarrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhaney @kharijarrett @viambot