Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA-568] Add cartographer integration tests #1544

Merged
merged 3 commits into from
Nov 2, 2022
Merged

[DATA-568] Add cartographer integration tests #1544

merged 3 commits into from
Nov 2, 2022

Conversation

tessavitabile
Copy link
Contributor

@tessavitabile tessavitabile commented Nov 1, 2022 •
edited
Loading

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 1, 2022
@tessavitabile tessavitabile mentioned this pull request Nov 1, 2022
Merged
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 1, 2022
@tessavitabile tessavitabile marked this pull request as ready for review November 1, 2022 18:44
kkufieta
kkufieta reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@kkufieta kkufieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few questions for my own understanding. Do I understand correctly that these integration tests will for now only work from within the SLAM repo? And once we have an app image, we can start running continuous integration from within RDK as well?

services/slam/builtin/cartographer_int_test.go Show resolved Hide resolved
services/slam/builtin/cartographer_int_test.go Outdated Show resolved Hide resolved
@tessavitabile
Copy link
Contributor Author

Do I understand correctly that these integration tests will for now only work from within the SLAM repo? And once we have an app image, we can start running continuous integration from within RDK as well?

Yes, that's correct. viamrobotics/slam#100 makes the github actions workflow for the slam repo run these integration tests. We need to have an app image before we can start running integration tests in the github actions workflow for the rdk repo. I included that in https://viam.atlassian.net/browse/DATA-701. The integration tests can also be run locally from the rdk repo if you have a carto_grpc_server binary in /usr/local/bin/.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 59% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 12% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% +0.34% ➖
go.viam.com/rdk/components/base 68% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 76% 0.00% ✅
go.viam.com/rdk/components/board 69% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 47% 0.00% ❌
go.viam.com/rdk/components/board/fake 39% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 66% +0.27% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 72% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 79% 0.00% ✅
go.viam.com/rdk/components/camera/videosource 55% -0.16% ➖
go.viam.com/rdk/components/encoder/fake 77% 0.00% ✅
go.viam.com/rdk/components/gantry 68% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 84% 0.00% ✅
go.viam.com/rdk/components/gripper 82% 0.00% ✅
go.viam.com/rdk/components/input 86% 0.00% ✅
go.viam.com/rdk/components/input/gpio 83% 0.00% ✅
go.viam.com/rdk/components/motor 82% 0.00% ✅
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 58% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 63% +0.45% ➖
go.viam.com/rdk/components/motor/gpiostepper 57% +0.59% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 67% 0.00% ➖
go.viam.com/rdk/components/movementsensor/cameramono 40% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 88% 0.00% ✅
go.viam.com/rdk/components/sensor 88% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% 0.00% ❌
go.viam.com/rdk/components/servo 77% 0.00% ✅
go.viam.com/rdk/config 77% +0.08% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/motionplan 71% +0.11% ✅
go.viam.com/rdk/operation 84% 0.00% ✅
go.viam.com/rdk/pointcloud 71% 0.00% ✅
go.viam.com/rdk/protoutils 62% 0.00% ➖
go.viam.com/rdk/referenceframe 78% 0.00% ✅
go.viam.com/rdk/registry 88% 0.00% ✅
go.viam.com/rdk/resource 85% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 93% 0.00% ✅
go.viam.com/rdk/robot/client 79% 0.00% ✅
go.viam.com/rdk/robot/framesystem 68% 0.00% ➖
go.viam.com/rdk/robot/impl 79% -0.24% ✅
go.viam.com/rdk/robot/server 58% -0.97% ➖
go.viam.com/rdk/robot/web 60% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 25% 0.00% ❌
go.viam.com/rdk/services/baseremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 71% 0.00% ✅
go.viam.com/rdk/services/datamanager 62% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 78% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 21% 0.00% ❌
go.viam.com/rdk/services/datamanager/datasync 72% 0.00% ✅
go.viam.com/rdk/services/motion 68% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 89% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 78% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 15% 0.00% ❌
go.viam.com/rdk/services/slam 86% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 73% 0.00% ✅
go.viam.com/rdk/services/vision 82% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/spatialmath 85% 0.00% ✅
go.viam.com/rdk/subtype 96% 0.00% ✅
go.viam.com/rdk/utils 71% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (19073 / 28835) +0.01% ➖

JohnN193
JohnN193 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@JohnN193 JohnN193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kkufieta
kkufieta approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@kkufieta kkufieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tessavitabile tessavitabile merged commit ddf6889 into viamrobotics:main Nov 2, 2022
@tessavitabile tessavitabile deleted the DATA-568 branch November 2, 2022 14:52
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnN193 JohnN193 JohnN193 approved these changes

@kkufieta kkufieta kkufieta approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tessavitabile @kkufieta @JohnN193 @viambot