motion methods should use ShortName()

[biotinker]

No description provided.

[edaniels]

shouldn't we update other parts to accept a full name? short name is riskier

[biotinker]

@edaniels Isn't that functionally what this is doing? Counterintuitively, Name yields just the name of the thing, while ShortName yields remote+name, which is how it is in the framesystem (that counterintuitiveness is the cause of this bug).

The only information that's not captured in ShortName is the subtype, but we shouldn't care about that for framesystem stuff, since ShortName should always be unique in a robot.

[edaniels]

there's the .String() which is the fully qualified name with all remotes involved

[biotinker]

.String() is subtype/remote:component, whereas ShortName is just remote:component.

Remote:component is what the framesystem uses, so that's what should be used here.

If we want the framesystem to use subtype/remote:component I'm not opposed to that but that should be coordinated with the RDK Components team, and also we probably shouldn't block this PR on that; this will fix the system as it currently exists, and that would be an improvement that re-updating this would be a part of.

[Fahmina]

LGTM

[bhaney]

Yay short name

[edaniels]

ah, yes. my bad!

[github-actions]

Package	Line Rate	Delta	Health
go.viam.com/rdk/components/arm	59%	0.00%	➖
go.viam.com/rdk/components/arm/universalrobots	12%	0.00%	❌
go.viam.com/rdk/components/arm/xarm	2%	0.00%	❌
go.viam.com/rdk/components/arm/yahboom	7%	0.00%	❌
go.viam.com/rdk/components/audioinput	55%	-0.34%	➖
go.viam.com/rdk/components/base	68%	0.00%	➖
go.viam.com/rdk/components/base/agilex	62%	0.00%	➖
go.viam.com/rdk/components/base/boat	41%	0.00%	❌
go.viam.com/rdk/components/base/wheeled	76%	0.00%	✅
go.viam.com/rdk/components/board	69%	0.00%	➖
go.viam.com/rdk/components/board/arduino	10%	0.00%	❌
go.viam.com/rdk/components/board/commonsysfs	47%	0.00%	❌
go.viam.com/rdk/components/board/fake	39%	0.00%	❌
go.viam.com/rdk/components/board/numato	19%	0.00%	❌
go.viam.com/rdk/components/board/pi	50%	0.00%	➖
go.viam.com/rdk/components/camera	66%	0.00%	➖
go.viam.com/rdk/components/camera/fake	67%	0.00%	➖
go.viam.com/rdk/components/camera/ffmpeg	72%	0.00%	✅
go.viam.com/rdk/components/camera/transformpipeline	80%	+0.40%	✅
go.viam.com/rdk/components/camera/videosource	55%	-0.48%	➖
go.viam.com/rdk/components/encoder/fake	77%	0.00%	✅
go.viam.com/rdk/components/gantry	68%	0.00%	➖
go.viam.com/rdk/components/gantry/multiaxis	84%	0.00%	✅
go.viam.com/rdk/components/gantry/oneaxis	86%	0.00%	✅
go.viam.com/rdk/components/generic	84%	0.00%	✅
go.viam.com/rdk/components/gripper	82%	0.00%	✅
go.viam.com/rdk/components/input	86%	0.00%	✅
go.viam.com/rdk/components/input/gpio	83%	0.00%	✅
go.viam.com/rdk/components/motor	82%	0.00%	✅
go.viam.com/rdk/components/motor/dimensionengineering	63%	0.00%	➖
go.viam.com/rdk/components/motor/dmc4000	69%	0.00%	➖
go.viam.com/rdk/components/motor/fake	58%	0.00%	➖
go.viam.com/rdk/components/motor/gpio	64%	0.00%	➖
go.viam.com/rdk/components/motor/gpiostepper	56%	-0.59%	➖
go.viam.com/rdk/components/motor/tmcstepper	62%	0.00%	➖
go.viam.com/rdk/components/movementsensor	67%	0.00%	➖
go.viam.com/rdk/components/movementsensor/cameramono	40%	0.00%	❌
go.viam.com/rdk/components/movementsensor/gpsnmea	37%	0.00%	❌
go.viam.com/rdk/components/movementsensor/gpsrtk	28%	0.00%	❌
go.viam.com/rdk/components/posetracker	88%	0.00%	✅
go.viam.com/rdk/components/sensor	88%	0.00%	✅
go.viam.com/rdk/components/sensor/ultrasonic	34%	0.00%	❌
go.viam.com/rdk/components/servo	77%	0.00%	✅
go.viam.com/rdk/config	77%	-0.08%	✅
go.viam.com/rdk/control	57%	0.00%	➖
go.viam.com/rdk/data	78%	+0.81%	✅
go.viam.com/rdk/grpc	25%	0.00%	❌
go.viam.com/rdk/ml	67%	0.00%	➖
go.viam.com/rdk/ml/inference	70%	0.00%	✅
go.viam.com/rdk/motionplan	71%	+2.12%	✅
go.viam.com/rdk/operation	81%	0.00%	✅
go.viam.com/rdk/pointcloud	71%	+0.09%	✅
go.viam.com/rdk/protoutils	62%	0.00%	➖
go.viam.com/rdk/referenceframe	78%	0.00%	✅
go.viam.com/rdk/registry	88%	0.00%	✅
go.viam.com/rdk/resource	85%	0.00%	✅
go.viam.com/rdk/rimage	78%	0.00%	✅
go.viam.com/rdk/rimage/depthadapter	94%	0.00%	✅
go.viam.com/rdk/rimage/transform	73%	0.00%	✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration	67%	0.00%	➖
go.viam.com/rdk/robot	93%	0.00%	✅
go.viam.com/rdk/robot/client	80%	0.00%	✅
go.viam.com/rdk/robot/framesystem	68%	0.00%	➖
go.viam.com/rdk/robot/impl	79%	0.00%	✅
go.viam.com/rdk/robot/server	58%	0.00%	➖
go.viam.com/rdk/robot/web	61%	0.00%	➖
go.viam.com/rdk/robot/web/stream	87%	0.00%	✅
go.viam.com/rdk/services/armremotecontrol	75%	0.00%	✅
go.viam.com/rdk/services/armremotecontrol/builtin	25%	0.00%	❌
go.viam.com/rdk/services/baseremotecontrol	75%	0.00%	✅
go.viam.com/rdk/services/baseremotecontrol/builtin	71%	0.00%	✅
go.viam.com/rdk/services/datamanager	62%	0.00%	➖
go.viam.com/rdk/services/datamanager/builtin	78%	0.00%	✅
go.viam.com/rdk/services/datamanager/datacapture	21%	0.00%	❌
go.viam.com/rdk/services/datamanager/datasync	72%	+0.29%	✅
go.viam.com/rdk/services/motion	68%	0.00%	➖
go.viam.com/rdk/services/motion/builtin	89%	0.00%	✅
go.viam.com/rdk/services/navigation	54%	0.00%	➖
go.viam.com/rdk/services/sensors	78%	0.00%	✅
go.viam.com/rdk/services/sensors/builtin	97%	0.00%	✅
go.viam.com/rdk/services/shell	15%	0.00%	❌
go.viam.com/rdk/services/slam	86%	0.00%	✅
go.viam.com/rdk/services/slam/builtin	73%	0.00%	✅
go.viam.com/rdk/services/vision	82%	0.00%	✅
go.viam.com/rdk/services/vision/builtin	74%	0.00%	✅
go.viam.com/rdk/spatialmath	85%	0.00%	✅
go.viam.com/rdk/subtype	96%	0.00%	✅
go.viam.com/rdk/utils	71%	0.00%	✅
go.viam.com/rdk/vision	26%	0.00%	❌
go.viam.com/rdk/vision/chess	80%	0.00%	✅
go.viam.com/rdk/vision/delaunay	87%	0.00%	✅
go.viam.com/rdk/vision/keypoints	92%	0.00%	✅
go.viam.com/rdk/vision/objectdetection	82%	0.00%	✅
go.viam.com/rdk/vision/odometry	60%	0.00%	➖
go.viam.com/rdk/vision/odometry/cmd	0%	0.00%	❌
go.viam.com/rdk/vision/segmentation	49%	0.00%	❌
go.viam.com/rdk/web/server	26%	0.00%	❌
Summary	66% (19254 / 29111)	+0.13%	➖