-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to go 1.19 (Includes [RSDK-776] fix) #1561
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Nov 4, 2022
edaniels
approved these changes
Nov 4, 2022
Otterverse
changed the title
Update to go 1.19
Update to go 1.19 (Includes [RSDK-776] fix)
Nov 4, 2022
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 4, 2022
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 4, 2022
Note: merge base coverage results not available, comparing against closest 99426ba~1=(54c9b34) instead
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for a new canon image I have ready. This is mostly linting. One real fix in inject.Robot. A tad hacky, but one test was changing an injected function on a "live" robot, and that hit a race in some testing. Rather than add a dozen+ functions to accept the functions, I set it up to rely on a test author manually locking/unlocking in the rare cases (only one test so far) that a function is swapped while the robot is being served.
Also, similar bumps/lint fixes are needed for api and goutils. After those merge, I'll update this with the new versions of those imports.