Use a production logger for sync for better sampling #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
agreenb
commented
Nov 8, 2022
edaniels
reviewed
Nov 13, 2022
| @@ -147,7 +147,7 @@ func (s *syncer) upload(ctx context.Context, path string) { | |||
| func(ctx context.Context) error { return s.uploadFile(ctx, s.client, f, s.partID) }, | |||
| s.logger, | |||
| ) | |||
| if uploadErr != nil { | |||
| if uploadErr != nil && !errors.Is(uploadErr, context.Canceled) { | |||
There was a problem hiding this comment.
if you do see context canceled still, let me know. it sometimes has a chance of being stringified by a library and loses its "value"
viambot
added
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since sync can spam a bunch of messages upon failure, limit these reasonably by using
NewProduction()which uses theNewProductionConfig: https://github.com/uber-go/zap/blob/master/FAQ.md#why-are-some-of-my-logs-missingAlso only log upload failure if it is not due to a canceled context, since that's expected when disabling sync.