Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSDK-867 create passthrough to use UR's planning for MoveToPosition calls #1579

Merged
merged 44 commits into from
Nov 14, 2022

Conversation

raybjork
Copy link
Member

@raybjork raybjork commented Nov 9, 2022

This PR adds a config attribute for the UR5 arm model that if set to be true will allow the arm to use UR's custom built planning rather than the default RDK motion planning.

Before creating this PR I tested the code on the physical arm and confirmed that it works as expected.

@raybjork raybjork added the safe to test This pull request is marked safe to test from a trusted zone label Nov 10, 2022
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Nov 10, 2022
@raybjork raybjork added the safe to test This pull request is marked safe to test from a trusted zone label Nov 10, 2022
Copy link
Member

@biotinker biotinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One update needed, one thing to look at, but otherwise looks good.

Copy link
Member

@biotinker biotinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Nov 11, 2022
@raybjork raybjork added the safe to test This pull request is marked safe to test from a trusted zone label Nov 11, 2022
@viambot viambot removed the safe to test This pull request is marked safe to test from a trusted zone label Nov 11, 2022
@github-actions
Copy link
Contributor

For security reasons, this PR must be labeled with safe to test in order for tests to run.

@raybjork raybjork added the safe to test This pull request is marked safe to test from a trusted zone label Nov 11, 2022
@raybjork raybjork requested a review from erh November 11, 2022 22:10
@raybjork raybjork merged commit 7688d8e into viamrobotics:main Nov 14, 2022
@raybjork raybjork deleted the ur branch November 14, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants