Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change model name of generic servo to gpio #1589

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Change model name of generic servo to gpio #1589

merged 3 commits into from
Nov 14, 2022

Conversation

randhid
Copy link
Member

@randhid randhid commented Nov 14, 2022

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 14, 2022
@edaniels edaniels changed the title Change model name Change model name of generic servo to gpio Nov 14, 2022
Fahmina
Fahmina approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@Fahmina Fahmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 14, 2022
penguinland
penguinland approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@penguinland penguinland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the two comments, and the rest LGTM

components/servo/gpio/servo_test.go Outdated Show resolved Hide resolved
components/servo/gpio/servo.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 14, 2022
@penguinland
Copy link
Member

Oh snap, very good catch renaming the constructors, too! I missed that.

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 59% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 12% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% +0.34% ➖
go.viam.com/rdk/components/base 68% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 76% 0.00% ✅
go.viam.com/rdk/components/board 69% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 47% 0.00% ❌
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 66% 0.00% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 77% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 80% +0.41% ✅
go.viam.com/rdk/components/camera/videosource 56% +0.67% ➖
go.viam.com/rdk/components/encoder/fake 77% 0.00% ✅
go.viam.com/rdk/components/gantry 68% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 84% 0.00% ✅
go.viam.com/rdk/components/gripper 81% 0.00% ✅
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/gpio 83% 0.00% ✅
go.viam.com/rdk/components/motor 82% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 58% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 63% -0.43% ➖
go.viam.com/rdk/components/motor/gpiostepper 56% -0.59% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 76% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 40% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 87% 0.00% ✅
go.viam.com/rdk/components/sensor 87% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% 0.00% ❌
go.viam.com/rdk/components/servo 79% 0.00% ✅
go.viam.com/rdk/components/servo/gpio 71% N/A ✅
go.viam.com/rdk/config 76% +0.08% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/motionplan 71% 0.00% ✅
go.viam.com/rdk/operation 81% 0.00% ✅
go.viam.com/rdk/pointcloud 71% 0.00% ✅
go.viam.com/rdk/protoutils 62% 0.00% ➖
go.viam.com/rdk/referenceframe 78% 0.00% ✅
go.viam.com/rdk/registry 88% 0.00% ✅
go.viam.com/rdk/resource 85% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 93% 0.00% ✅
go.viam.com/rdk/robot/client 81% 0.00% ✅
go.viam.com/rdk/robot/framesystem 68% 0.00% ➖
go.viam.com/rdk/robot/impl 79% +0.12% ✅
go.viam.com/rdk/robot/server 58% 0.00% ➖
go.viam.com/rdk/robot/web 61% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 25% 0.00% ❌
go.viam.com/rdk/services/baseremotecontrol 75% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 66% 0.00% ➖
go.viam.com/rdk/services/datamanager 66% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 80% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 21% 0.00% ❌
go.viam.com/rdk/services/datamanager/datasync 72% 0.00% ✅
go.viam.com/rdk/services/motion 68% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 89% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 78% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 14% 0.00% ❌
go.viam.com/rdk/services/slam 85% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 72% 0.00% ✅
go.viam.com/rdk/services/vision 80% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/spatialmath 85% 0.00% ✅
go.viam.com/rdk/subtype 96% 0.00% ✅
go.viam.com/rdk/utils 71% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 66% (19509 / 29443) +0.02% ➖

@randhid randhid merged commit 9d51722 into viamrobotics:main Nov 14, 2022
@randhid randhid deleted the change-geenric-to-gpio branch November 14, 2022 18:14
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fahmina Fahmina Fahmina approved these changes

@penguinland penguinland penguinland approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randhid @penguinland @Fahmina @viambot