RSDK-801: Change default logger to be pretty (ISO formatted) #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
dannenberg
reviewed
Nov 23, 2022
web/server/entrypoint.go
Outdated
| @@ -57,7 +57,7 @@ func RunServer(ctx context.Context, args []string, _ golog.Logger) (err error) { | |||
| if argsParsed.Debug { | |||
| logConfig = golog.NewDebugLoggerConfig() | |||
| } else { | |||
| logConfig = golog.NewProductionLoggerConfig() | |||
| logConfig = golog.NewDevelopmentLoggerConfig() | |||
There was a problem hiding this comment.
in addition to changing the timestamp format, this appears to set Development to true and change the EncodeLevel to zapcore.CapitalColorLevelEncoder from zapcore.LowercaseLevelEncoder.
are those safe/desirable changes?
There was a problem hiding this comment.
the former change i do not understand, but seems likely undesirable (setting Development: true to production builds).
the latter i'm fairly confident we do not want. colors are typically implemented via escape codes and will not render correctly in many places.
There was a problem hiding this comment.
fair, did a less invasive change - just updates the time encoder to ISO
There was a problem hiding this comment.
logs look like this now 2022-11-23T16:32:27.338-0500 info robot_server rpc/server.go:739 stopped cleanly
viambot
added
safe to test
|
dannenberg
approved these changes
Nov 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cannot repro the other part, so just fixing this part first