[RSDK-448] Add Partial Start option to robot config #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kschappacher
added
the
safe to test
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
cheukt
requested changes
Nov 23, 2022
|
also there are a few more cases in the ticket which should be covered by the tests - you should add those |
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
cheukt
reviewed
Nov 30, 2022
config/config.go
Outdated
| @@ -46,6 +46,10 @@ type Config struct { | |||
| // If false, it's for creating a robot via the RDK library. This is helpful for | |||
| // error messages that can indicate flags/config fields to use. | |||
| FromCommand bool `json:"-"` | |||
|
|
|||
| // DisablepartialStart ensures that a robot will only start when all the components, | |||
There was a problem hiding this comment.
nit: DisablepartialStart -> DisablePartialStart
There was a problem hiding this comment.
fixed the nit, added the two test cases in the AC of the story and added the proto story https://viam.atlassian.net/browse/RSDK-918
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
cheukt
approved these changes
Dec 1, 2022
robot/impl/local_robot_test.go
Outdated
| test.That(t, ok, test.ShouldBeFalse) | ||
|
|
||
| r.Reconfigure(ctx, goodConfig) | ||
| // Test Component Error |
There was a problem hiding this comment.
nit: these aren't errors anymore?
robot/impl/local_robot_test.go
Outdated
| Cloud: &config.Cloud{}, | ||
| } | ||
| // Test Component Error | ||
| noBase, err := r.ResourceByName(base.Named("test")) |
There was a problem hiding this comment.
nit: over here too. we can also use base.FromRobot(r, "test")
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
viambot
removed
the
safe to test
Kschappacher
added
the
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow robots to start even if one component does not pass config validation. We want this to be the default behavior for robots so the new disablepartialstart cofig field is set to false by default and does not need to be added to the config. if a user wishes to disable this behavior they can set disablepartialstart to true in the robot config.