rc: use new client from sdk #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
edaniels
commented
Nov 23, 2022
| curStates.Menu = trunc(gamepad.buttons[16]!.value); | ||
| // TODO(RSDK-881): this ought to detect actual controller mappings; for now | ||
| // just try to not fail. | ||
| curStates.X = trunc(gamepad.axes[0]); |
edaniels
commented
Nov 23, 2022
| @@ -1,5 +1,6 @@ | |||
| <!-- eslint-disable require-atomic-updates --> | |||
| <script setup lang="ts"> | |||
|
|
|||
There was a problem hiding this comment.
this actually contains a lot of driveby bug fixes that improves RC reliability
edaniels
commented
Nov 23, 2022
| @@ -0,0 +1,151 @@ | |||
| /* | |||
| Package main provides a utility to run a remote control only web server. It is configured with | |||
There was a problem hiding this comment.
this helps test RC against app
maximpertsov
approved these changes
Nov 23, 2022
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
edaniels
commented
Nov 24, 2022
| @@ -25,23 +25,26 @@ | |||
| {{ else if eq .Env "development" }} | |||
| <script type="module">window.PRIME_CONFIG = { base: '/static' }</script> | |||
| {{ end }} | |||
|
|
|||
| <script id="_timeout_worker" type="javascript/worker"> | |||
There was a problem hiding this comment.
saving this for something special :)
edaniels
commented
Nov 24, 2022
| @@ -280,7 +284,7 @@ onMounted(() => { | |||
| class="mb-2" | |||
| @keydown="handleKeyDown" | |||
| @keyup="handleKeyUp" | |||
| @toggle="(active: boolean) => !active && stop()" | |||
| @toggle="(active: boolean) => { !active && (pressed.size > 0 || !stopped) && stop() }" | |||
There was a problem hiding this comment.
more fixes for off focus
edaniels
commented
Nov 24, 2022
| @@ -64,7 +65,7 @@ const relevantSubtypesForStatus = [ | |||
| 'input_controller', | |||
| ]; | |||
|
|
|||
| const passwordInput = $ref<HTMLInputElement>(); | |||
| const password = $ref<string>(''); | |||
There was a problem hiding this comment.
this helps password auth work again
edaniels
commented
Nov 24, 2022
| @@ -481,10 +475,11 @@ const createConnectionManager = () => { | |||
|
|
|||
| statuses.ops = true; | |||
| } catch (error) { | |||
| if (error instanceof ConnectionClosedError) { | |||
| if (ConnectionClosedError.isError(error)) { | |||
edaniels
commented
Nov 24, 2022
| await fetchCurrentOps(); | ||
| lastStatusTS = Date.now(); | ||
| console.log('reconnected'); | ||
| } catch (error) { | ||
| console.error('failed to reconnect; retrying:', error); | ||
| if (ConnectionClosedError.isError(error)) { |
edaniels
commented
Nov 24, 2022
| return rawStatus[resourceNameToString(resource)]; | ||
| }; | ||
|
|
||
| const hasWebGamepad = () => { | ||
| const filteredWebGamepads = () => { |
edaniels
commented
Nov 24, 2022
| /> | ||
| <div class="px-4 py-3"> | ||
| <span>{{ authType }}: </span> | ||
| <div class="w-96"> |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.