RSDK-914 - Implement session manager and client support #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
requested review from
stevebriskin and
cheukt
and removed request for
stevebriskin
|
FYI @stevebriskin: not required for review but add yourself if you'd like! |
viambot
added
safe to test
viambot
added
safe to test
cheukt
approved these changes
Dec 1, 2022
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
edaniels
commented
Dec 10, 2022
| @@ -146,7 +146,7 @@ func TestBaseRemoteControl(t *testing.T) { | |||
| }, | |||
| logger) | |||
| test.That(t, err, test.ShouldBeError, | |||
| errors.New("dependency \"baseTest\" should an implementation of <nil> but it was a *inject.InputController")) | |||
| errors.New("dependency \"baseTest\" should be an implementation of base.Base but it was a *inject.InputController")) | |||
viambot
added
safe to test
edaniels
commented
Dec 10, 2022
| @@ -121,17 +121,17 @@ var ( | |||
|
|
|||
| // NewUnimplementedInterfaceError is used when there is a failed interface check. | |||
| func NewUnimplementedInterfaceError(actual interface{}) error { | |||
| return utils.NewUnimplementedInterfaceError((Arm)(nil), actual) | |||
| return utils.NewUnimplementedInterfaceError((*Arm)(nil), actual) | |||
There was a problem hiding this comment.
@cheukt this was not working
edaniels
commented
Dec 10, 2022
| Name string `json:"name"` | ||
| Address string `json:"address"` | ||
| Frame *Frame `json:"frame,omitempty"` | ||
| Auth RemoteAuth `json:"auth"` | ||
| ManagedBy string `json:"managed_by"` | ||
| Insecure bool `json:"insecure"` | ||
| ConnectionCheckInterval time.Duration `json:"connection_check_interval,omitempty"` | ||
| ReconnectInterval time.Duration `json:"reconnect_interval,omitempty"` | ||
| ConnectionCheckInterval string `json:"connection_check_interval,omitempty"` |
There was a problem hiding this comment.
@cheukt neither was this
viambot
added
safe to test
viambot
added
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JIRA for a copy of the scope. This is ready to review but still needs: