-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JPEG hint to app video streams #1635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaney
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Dec 2, 2022
viambot
removed
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Dec 2, 2022
bhaney
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Dec 2, 2022
Going to test this now on my own computer using a remote camera on my desk |
|
Yea, it looks like it is JPEG now!
and it looks like it's up to around 10 fps too |
edaniels
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it works
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, app gets back RawRGBALazy images by default from remote cameras.
This switches all camera streams to request JPEGLazy frames from the cameras if they are using a gRPC GetImage() method.
The alternative could be to change the camera/client.go default request to be empty ( rather than the current default to request RawRGBALazy) such that the server can provide its own default MIME type in the response.