[DATA-611] Fix cartographer integration test

[kkufieta]

Ticket: https://viam.atlassian.net/browse/DATA-661

This is a fix that's necessary for this PR to go through: viamrobotics/slam#116

[github-actions]

Package	Line Rate	Delta	Health
go.viam.com/rdk/components/arm	61%	0.00%	➖
go.viam.com/rdk/components/arm/universalrobots	13%	0.00%	❌
go.viam.com/rdk/components/arm/xarm	2%	0.00%	❌
go.viam.com/rdk/components/arm/yahboom	7%	0.00%	❌
go.viam.com/rdk/components/audioinput	55%	0.00%	➖
go.viam.com/rdk/components/base	67%	0.00%	➖
go.viam.com/rdk/components/base/agilex	62%	0.00%	➖
go.viam.com/rdk/components/base/boat	41%	0.00%	❌
go.viam.com/rdk/components/base/wheeled	76%	0.00%	✅
go.viam.com/rdk/components/board	68%	0.00%	➖
go.viam.com/rdk/components/board/arduino	10%	0.00%	❌
go.viam.com/rdk/components/board/commonsysfs	47%	0.00%	❌
go.viam.com/rdk/components/board/fake	38%	0.00%	❌
go.viam.com/rdk/components/board/numato	19%	0.00%	❌
go.viam.com/rdk/components/board/pi	50%	0.00%	➖
go.viam.com/rdk/components/camera	65%	0.00%	➖
go.viam.com/rdk/components/camera/fake	67%	0.00%	➖
go.viam.com/rdk/components/camera/ffmpeg	77%	0.00%	✅
go.viam.com/rdk/components/camera/transformpipeline	78%	+0.33%	✅
go.viam.com/rdk/components/camera/videosource	55%	-0.51%	➖
go.viam.com/rdk/components/encoder/fake	77%	0.00%	✅
go.viam.com/rdk/components/gantry	68%	0.00%	➖
go.viam.com/rdk/components/gantry/multiaxis	84%	0.00%	✅
go.viam.com/rdk/components/gantry/oneaxis	86%	0.00%	✅
go.viam.com/rdk/components/generic	83%	0.00%	✅
go.viam.com/rdk/components/gripper	80%	0.00%	✅
go.viam.com/rdk/components/input	87%	0.00%	✅
go.viam.com/rdk/components/input/gpio	83%	0.00%	✅
go.viam.com/rdk/components/motor	81%	0.00%	✅
go.viam.com/rdk/components/motor/dimensionengineering	63%	0.00%	➖
go.viam.com/rdk/components/motor/dmc4000	69%	0.00%	➖
go.viam.com/rdk/components/motor/fake	57%	0.00%	➖
go.viam.com/rdk/components/motor/gpio	63%	0.00%	➖
go.viam.com/rdk/components/motor/gpiostepper	56%	0.00%	➖
go.viam.com/rdk/components/motor/tmcstepper	62%	0.00%	➖
go.viam.com/rdk/components/movementsensor	75%	0.00%	✅
go.viam.com/rdk/components/movementsensor/cameramono	40%	0.00%	❌
go.viam.com/rdk/components/movementsensor/gpsnmea	37%	0.00%	❌
go.viam.com/rdk/components/movementsensor/gpsrtk	28%	0.00%	❌
go.viam.com/rdk/components/posetracker	86%	0.00%	✅
go.viam.com/rdk/components/sensor	86%	0.00%	✅
go.viam.com/rdk/components/sensor/ultrasonic	34%	0.00%	❌
go.viam.com/rdk/components/servo	78%	0.00%	✅
go.viam.com/rdk/components/servo/gpio	71%	0.00%	✅
go.viam.com/rdk/config	76%	-0.08%	✅
go.viam.com/rdk/control	57%	0.00%	➖
go.viam.com/rdk/data	77%	0.00%	✅
go.viam.com/rdk/grpc	25%	0.00%	❌
go.viam.com/rdk/ml	67%	0.00%	➖
go.viam.com/rdk/ml/inference	70%	0.00%	✅
go.viam.com/rdk/motionplan	68%	0.00%	➖
go.viam.com/rdk/octree	93%	0.00%	✅
go.viam.com/rdk/operation	82%	0.00%	✅
go.viam.com/rdk/pointcloud	71%	0.00%	✅
go.viam.com/rdk/protoutils	62%	0.00%	➖
go.viam.com/rdk/referenceframe	69%	0.00%	➖
go.viam.com/rdk/registry	88%	0.00%	✅
go.viam.com/rdk/resource	83%	0.00%	✅
go.viam.com/rdk/rimage	78%	0.00%	✅
go.viam.com/rdk/rimage/depthadapter	94%	0.00%	✅
go.viam.com/rdk/rimage/transform	73%	0.00%	✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration	67%	0.00%	➖
go.viam.com/rdk/robot	93%	0.00%	✅
go.viam.com/rdk/robot/client	79%	0.00%	✅
go.viam.com/rdk/robot/framesystem	68%	0.00%	➖
go.viam.com/rdk/robot/impl	81%	0.00%	✅
go.viam.com/rdk/robot/server	58%	0.00%	➖
go.viam.com/rdk/robot/web	60%	0.00%	➖
go.viam.com/rdk/robot/web/stream	87%	0.00%	✅
go.viam.com/rdk/services/armremotecontrol	71%	0.00%	✅
go.viam.com/rdk/services/armremotecontrol/builtin	25%	0.00%	❌
go.viam.com/rdk/services/baseremotecontrol	71%	0.00%	✅
go.viam.com/rdk/services/baseremotecontrol/builtin	66%	0.00%	➖
go.viam.com/rdk/services/datamanager	65%	0.00%	➖
go.viam.com/rdk/services/datamanager/builtin	80%	0.00%	✅
go.viam.com/rdk/services/datamanager/datacapture	21%	0.00%	❌
go.viam.com/rdk/services/datamanager/datasync	72%	0.00%	✅
go.viam.com/rdk/services/motion	63%	0.00%	➖
go.viam.com/rdk/services/motion/builtin	88%	0.00%	✅
go.viam.com/rdk/services/navigation	54%	0.00%	➖
go.viam.com/rdk/services/sensors	77%	0.00%	✅
go.viam.com/rdk/services/sensors/builtin	97%	0.00%	✅
go.viam.com/rdk/services/shell	14%	0.00%	❌
go.viam.com/rdk/services/slam	84%	0.00%	✅
go.viam.com/rdk/services/slam/builtin	72%	0.00%	✅
go.viam.com/rdk/services/vision	80%	0.00%	✅
go.viam.com/rdk/services/vision/builtin	74%	0.00%	✅
go.viam.com/rdk/spatialmath	85%	0.00%	✅
go.viam.com/rdk/subtype	96%	0.00%	✅
go.viam.com/rdk/utils	71%	0.00%	✅
go.viam.com/rdk/vision	26%	0.00%	❌
go.viam.com/rdk/vision/chess	80%	0.00%	✅
go.viam.com/rdk/vision/delaunay	87%	0.00%	✅
go.viam.com/rdk/vision/keypoints	92%	0.00%	✅
go.viam.com/rdk/vision/objectdetection	82%	0.00%	✅
go.viam.com/rdk/vision/odometry	60%	0.00%	➖
go.viam.com/rdk/vision/odometry/cmd	0%	0.00%	❌
go.viam.com/rdk/vision/segmentation	49%	0.00%	❌
go.viam.com/rdk/web/server	26%	0.00%	❌
Summary	66% (19745 / 29973)	-0.01%	➖

[tessavitabile]

For now, can you change this to check for either line? And then remove the old line after the other PR is merged?

[kkufieta]

For now, can you change this to check for either line? And then remove the old line after the other PR is merged?

@tessavitabile Do you mean like this?

if strings.Contains(line, "Finished processing offline data") || strings.Contains(line, "Finished optimizing final map") {
			break
		}

If so, then that won't work for the new PR since we'll exit the for loop as soon as we finish processing offline data. At that point in time the optimization is still running, and since we now return "the most recent map generated" - which does not have any points yet - we receive an error message rather than nil.

Changing the code as I suggested on the other hand works for both the current version of slam as well as for the PR I currently have open.

[tessavitabile]

Ah, thanks for explaining!