-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Control page, stop movement on pointerup
and pointerleave
events
#1649
Merged
mrloureed
merged 3 commits into
viamrobotics:main
from
mrloureed:bugfix-pointer-events-keyboard
Dec 7, 2022
Merged
Bugfix: Control page, stop movement on pointerup
and pointerleave
events
#1649
mrloureed
merged 3 commits into
viamrobotics:main
from
mrloureed:bugfix-pointer-events-keyboard
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Dec 7, 2022
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Dec 7, 2022
|
DTCurrie
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix:
pointerup
andpointerleave
eventsThis prevents a button from remaining pressed if a user drags outside of button while clicked.