[RSDK-1015] Ignore garbage bits from MCP3008 ADC chip #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
penguinland
commented
Dec 9, 2022
components/board/mcp3008.go
Outdated
| @@ -31,7 +31,9 @@ func (mar *MCP3008AnalogReader) Read(ctx context.Context, extra map[string]inter | |||
| if err != nil { | |||
| return 0, err | |||
| } | |||
| val := (int(rx[1]) << 8) | int(rx[2]) // reassemble 10 bit value | |||
| // Reassemble the 10-bit value. Do not include bits beyond the final 10, because they contain | |||
There was a problem hiding this comment.
"Beyond" implies "past the end," but we really want to exclude bits before the final 10. Rephrase this.
viambot
added
safe to test
thegreatco
approved these changes
Dec 9, 2022
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried at my desk with a Jetson Orin. Without this change, sometimes I read the correct value, and sometimes a value 64,000ish too large. With this change, it's always the correct one, somewhere between 0 and 1023 (both of which I can get by trying to read the ground pin or the hot pin).