RSDK-910 use sdk camera client #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
9e28820 to
7280e7f
Compare
viambot
added
safe to test
maximpertsov
commented
Dec 9, 2022
web/frontend/package.json
Outdated
| @@ -8,7 +8,7 @@ | |||
| "@mdi/js": "^6.9.96", | |||
| "@viamrobotics/prime": "^0.0.79", | |||
| "@viamrobotics/rpc": "^0.1.32", | |||
| "@viamrobotics/sdk": "^0.0.6", | |||
| "@viamrobotics/sdk": "file:../../../../viamrobotics/viam-typescript-sdk/viamrobotics-sdk-0.0.8.tgz", | |||
There was a problem hiding this comment.
bump version once viamrobotics/viam-typescript-sdk#6 is merged and the corresponding package is released
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
ac3a2bb to
7102cd3
Compare
viambot
added
safe to test
DTCurrie
reviewed
Dec 12, 2022
web/frontend/src/app.vue
Outdated
| @@ -611,26 +612,21 @@ const filteredInputControllerList = () => { | |||
| }; | |||
|
|
|||
| const viewFrame = (cameraName: string) => { | |||
There was a problem hiding this comment.
Nit: We could rewrite this to use the async/await syntax, but not really required:
const viewFrame = async (cameraName: string) => {
try {
const blob = await new CameraClient(client, cameraName).renderFrame(Camera.MimeType.JPEG);
const streamContainers = document.querySelectorAll(
`[data-stream="${cameraName}"]`
);
for (const streamContainer of streamContainers) {
streamContainer.querySelector('video')?.remove();
streamContainer.querySelector('img')?.remove();
const image = new Image();
image.src = URL.createObjectURL(blob);
streamContainer.append(image);
}
} catch (error) {
displayError(error);
}
};There was a problem hiding this comment.
yep, I will also add a linting rule to enforce the house style
DTCurrie
reviewed
Dec 12, 2022
| @@ -66,16 +65,14 @@ const toggleExpand = () => { | |||
| }; | |||
|
|
|||
| const renderPCD = () => { | |||
There was a problem hiding this comment.
Nit: This could also use the async/await syntax:
const renderPCD = async () => {
try {
const bytes = await new CameraClient(props.client, props.cameraName).getPointCloud();
pointcloud = bytes;
} catch (error) {
toast.error(`Error getting point cloud: ${error}`);
}
};
DTCurrie
reviewed
Dec 12, 2022
| @@ -102,18 +99,12 @@ const refreshCamera = () => { | |||
| }; | |||
|
|
|||
| const exportScreenshot = (cameraName: string) => { | |||
There was a problem hiding this comment.
Nit: Last one:
const exportScreenshot = async (cameraName: string) => {
try {
const blob = await new CameraClient(props.client, cameraName).renderFrame(Camera.MimeType.JPEG);
window.open(URL.createObjectURL(blob), '_blank');
} catch (error) {
displayError(error)
}
};
DTCurrie
approved these changes
Dec 12, 2022
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
7e565f7 to
4321180
Compare
viambot
added
safe to test
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
5588213 to
e469d19
Compare
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
e469d19 to
8386f39
Compare
viambot
added
safe to test
maximpertsov
force-pushed
the
RSDK-910-add-ts-wrapper-for-camera
branch
from
8386f39 to
ed40bb1
Compare
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
|
edaniels
approved these changes
Dec 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://viam.atlassian.net/browse/RSDK-910
TODO