RC: change default motor and base power/speed values #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebriskin
commented
Dec 9, 2022
| @@ -39,7 +39,7 @@ const direction = ref<Directions>('Forwards'); | |||
| const spinType = ref<SpinTypes>('Clockwise'); | |||
| const increment = ref(1000); | |||
| // straight mm/s | |||
| const speed = ref(200); | |||
| const speed = ref(300); | |||
stevebriskin
commented
Dec 9, 2022
|
|
||
| const position = $ref(0); | ||
| const rpm = $ref(0); | ||
| const power = $ref(25); | ||
| const power = $ref(50); |
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motor: the default power value was 25, but most motors only start moving around 30%. Changed the default value to 50%.
Base: low end bases like the new viam rover and yahboom style TT motors + wheels end up at ~35% power at the 200mm/s default value, which results in delayed, jerky, and sometimes no movement at all. Increasing that to 300mm/s will put those motors above 50%, which results in smoother operation.
All other changes are lint-related.
CC @michaellee1019 @nataliajacobowitz