Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DATA-701] add cartographer integration tests for rdk #1660

Merged
merged 33 commits into from
Dec 16, 2022
Merged

[DATA-701] add cartographer integration tests for rdk #1660

merged 33 commits into from
Dec 16, 2022

Conversation

JohnN193
Copy link
Member

@JohnN193 JohnN193 commented Dec 12, 2022 •
edited
Loading

add integration tests for cartographer by grabbing latest binary, as well as adding several other tests for cartographer

A passing integration test is located here https://github.com/viamrobotics/rdk/actions/runs/3706557424

https://viam.atlassian.net/browse/DATA-701

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@JohnN193 JohnN193 changed the title add initial carto integration tests [DATA-703] add cartographer integration tests Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@JohnN193 JohnN193 changed the title [DATA-703] add cartographer integration tests [DATA-701] add cartographer integration tests Dec 12, 2022
@JohnN193 JohnN193 changed the title [DATA-701] add cartographer integration tests [DATA-701] add cartographer integration tests for rdk Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 12, 2022
@JohnN193 JohnN193 requested a review from a user December 15, 2022 17:44
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 15, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 15, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 15, 2022
ghost
ghost approved these changes Dec 16, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

services/slam/builtin/orbslam_int_test.go Outdated
// Clear out directory
closeOutSLAMService(t, name)

}

// Checks the current slam directory to see if the number of files exceeds the expecteed amount
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] equals... (plus a note about the maps)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add a less than or equal check on on the maps as well to do a "is between" check.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 16, 2022
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 61% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 13% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% -0.34% ➖
go.viam.com/rdk/components/base 67% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 76% 0.00% ✅
go.viam.com/rdk/components/board 68% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 47% 0.00% ❌
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 65% 0.00% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 77% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 78% +0.33% ✅
go.viam.com/rdk/components/camera/videosource 55% 0.00% ➖
go.viam.com/rdk/components/encoder/fake 77% 0.00% ✅
go.viam.com/rdk/components/gantry 68% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 83% 0.00% ✅
go.viam.com/rdk/components/gripper 80% 0.00% ✅
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/gpio 84% 0.00% ✅
go.viam.com/rdk/components/motor 81% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 57% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 63% -0.43% ➖
go.viam.com/rdk/components/motor/gpiostepper 57% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 40% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 37% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 86% 0.00% ✅
go.viam.com/rdk/components/sensor 86% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 34% 0.00% ❌
go.viam.com/rdk/components/servo 78% 0.00% ✅
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 77% +0.07% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 77% 0.00% ✅
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/motionplan 68% 0.00% ➖
go.viam.com/rdk/octree 98% 0.00% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 72% 0.00% ✅
go.viam.com/rdk/protoutils 59% 0.00% ➖
go.viam.com/rdk/referenceframe 71% 0.00% ✅
go.viam.com/rdk/registry 90% 0.00% ✅
go.viam.com/rdk/resource 83% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 85% 0.00% ✅
go.viam.com/rdk/robot/client 82% 0.00% ✅
go.viam.com/rdk/robot/framesystem 68% 0.00% ➖
go.viam.com/rdk/robot/impl 81% 0.00% ✅
go.viam.com/rdk/robot/server 57% 0.00% ➖
go.viam.com/rdk/robot/web 60% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 52% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 79% 0.00% ✅
go.viam.com/rdk/services/datamanager 65% 0.00% ➖
go.viam.com/rdk/services/datamanager/builtin 80% 0.00% ✅
go.viam.com/rdk/services/datamanager/datacapture 21% 0.00% ❌
go.viam.com/rdk/services/datamanager/datasync 72% 0.00% ✅
go.viam.com/rdk/services/motion 63% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 88% 0.00% ✅
go.viam.com/rdk/services/navigation 54% 0.00% ➖
go.viam.com/rdk/services/sensors 77% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 14% 0.00% ❌
go.viam.com/rdk/services/slam 84% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 72% 0.00% ✅
go.viam.com/rdk/services/vision 80% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 85% 0.00% ✅
go.viam.com/rdk/subtype 96% 0.00% ✅
go.viam.com/rdk/utils 72% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 26% 0.00% ❌
Summary 67% (20407 / 30672) 0.00% ➖

@JohnN193 JohnN193 merged commit 0dee270 into main Dec 16, 2022
@JohnN193 JohnN193 deleted the DATA-701 branch December 16, 2022 20:47
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Otterverse Otterverse Otterverse approved these changes

@tessavitabile tessavitabile tessavitabile approved these changes

@kkufieta kkufieta kkufieta approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JohnN193 @kkufieta @Otterverse @tessavitabile @viambot