RSDK-730 : RDK fails to shutdown when connected to serial components #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
susmitaSanyal
added
the
safe to test
gvaradarajan
requested changes
Dec 13, 2022
| if !isValid { | ||
|
|
||
| fmt.Print("\n") | ||
| fmt.Print("Please enter values from: ") |
There was a problem hiding this comment.
instead of the InvalidIntegerValue function, could we make a specific InvalidBaudRate function in this file and have the print statements here be the message of the error returned by that function?
viambot
added
safe to test
randhid
requested changes
Dec 13, 2022
randhid
reviewed
Dec 13, 2022
viambot
added
safe to test
randhid
requested changes
Dec 14, 2022
| // AttrConfig is used for converting a witmotion IMU MovementSensor config attributes. | ||
| type AttrConfig struct { | ||
| Port string `json:"serial_path"` | ||
| BaudRate int `json:"serial_baud_rate,omitempty"` | ||
| } | ||
|
|
||
| // Validate ensures all parts of the config are valid. | ||
| func (cfg *AttrConfig) Validate(path string) error { | ||
| func (cfg *AttrConfig) Validate(path string, logger golog.Logger) error { |
There was a problem hiding this comment.
we can;t add a logger to the Validate function. The signature now doesn't match the types we have in resource.go, remove the logger input. you're not using it anyway.
There was a problem hiding this comment.
oppps, good catch, I forgot to remove it.
viambot
added
safe to test
|
gvaradarajan
approved these changes
Dec 14, 2022
randhid
approved these changes
Dec 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues that were causing this error:
Baud rate validation is done by comparing the given baud rate from config file with the applicable baud rates found in Wit devices.
Added port closing in close function. Close will error if we loose connection to the serial port.