-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-1248 Add copy arm position and joint values buttons #1670
RSDK-1248 Add copy arm position and joint values buttons #1670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Otterverse @edaniels Seeing the same issue where no matter what the CI is generating a different |
I re-cloned and it appears to have worked. We talked about potentially ignored files causing this but a quick glance I am not sure what it would be. I do think we have talked about no longer committing the front-end build artifacts so if we want to move forward with that I would be more than happy to schedule a meeting and get the work down in tickets for us to prioritize. |
|
So rather than reclone, you can just do a git clean, which will remove untracked/ignored files. There's a |
And yes, I'd love if we can stop committing generated artifacts! Might be easier to do if we were to split the frontend out of RDK per https://viam.atlassian.net/browse/PRODUCT-265 first. |
Yes we should stop committing the artifacts. Splitting it right now adds
too much effort and pushes the issues down anyway. I'll work on this soon
…On Wednesday, December 14, 2022, James Otting ***@***.***> wrote:
And yes, I'd love if we can stop committing generated artifacts! Might be
easier to do if we were to split the frontend out of RDK per
https://viam.atlassian.net/browse/PRODUCT-265 first.
—
Reply to this email directly, view it on GitHub
<#1670 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGU2QQLFJ5JWOYVEIIXFSDWNJKDZANCNFSM6AAAAAAS66YSJY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Added some copy buttons to help out @nataliajacobowitz with her project.