Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-923] Make GPS-RTK code more robust, remove bad test #1679

Merged
merged 11 commits into from
Jan 5, 2023
Merged

[RSDK-923] Make GPS-RTK code more robust, remove bad test #1679

merged 11 commits into from
Jan 5, 2023

Commits on Dec 16, 2022

  1. Replace go statements with utils.PanicCapturingGo

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    0372bbd View commit details
    Browse the repository at this point in the history

  2. don't leak goroutines if there's an error

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    e889c50 View commit details
    Browse the repository at this point in the history

  3. rename errMu -> mu

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c95fc2d View commit details
    Browse the repository at this point in the history

  4. Use the mutex when interacting with lastError

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    ba05f01 View commit details
    Browse the repository at this point in the history

  5. Use mutex for other data, too

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    355b373 View commit details
    Browse the repository at this point in the history

  6. debugging

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    783fc1c View commit details
    Browse the repository at this point in the history

  7. remove test that is flaky due to third-party code

    @penguinland
    penguinland committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c5b0414 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Prefer Lock...Unlock on a mutex instead of an anonymous function for … 

    …simple things
    @penguinland
    penguinland committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    c8c6ee2 View commit details
    Browse the repository at this point in the history

  2. pr feedback: add TODO

    @penguinland
    penguinland committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    13c6f9a View commit details
    Browse the repository at this point in the history

  3. Start should use the cancelCtx from within itself

    @penguinland
    penguinland committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    30d9c99 View commit details
    Browse the repository at this point in the history

  4. make lint

    @penguinland
    penguinland committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    fe7c858 View commit details
    Browse the repository at this point in the history