[DATA-671-fix] Set file extension in upload requests; actually test metadata in sync_test. #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
agreenb
approved these changes
Dec 27, 2022
| @@ -497,15 +498,23 @@ func compareSensorData(t *testing.T, dataType v1.DataType, act []*v1.SensorData, | |||
| return | |||
| } | |||
|
|
|||
| //TODO: metadata checks fail because these don't get uploaded in a defined order. should prob use sets instead | |||
| // of arrays. For now, just don't check metadata | |||
| // Sort both by time requested. | |||
viambot
added
safe to test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't setting file extension, so all binary captures we're being saved as mime_type octet stream. This fixes that. Also fixes/adds the metadata testing to avoid this in the future.