Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-1612] Update data CLI usage text #1711

Merged
merged 3 commits into from
Dec 28, 2022
Merged

Conversation

agreenb
Copy link
Contributor

@agreenb agreenb commented Dec 28, 2022

Update data command usage text with the corresponding export and delete subcommands.

@agreenb agreenb requested review from AaronCasas and tahiyasalam and removed request for AaronCasas December 28, 2022 17:13
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 28, 2022
@agreenb agreenb changed the title [DATA-967] Update data CLI usage text [RSDK-1612] Update data CLI usage text Dec 28, 2022
@@ -218,7 +218,7 @@ func main() {
{
Name: "export",
Usage: "download data from Viam cloud",
UsageText: fmt.Sprintf("viam data <%s> <%s> [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s] [%s]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the <> versus [] was for required versus optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the catch! Updated back.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 28, 2022
Copy link
Member

@tahiyasalam tahiyasalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 28, 2022
@agreenb agreenb merged commit 4fef6ed into viamrobotics:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants