RSDK-1627 - Add generic DoCommand support for modules #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
edaniels
suggested changes
Jan 4, 2023
| if name.Subtype.ResourceType == resource.ResourceTypeComponent && name.Subtype != generic.Subtype { | ||
| genSvc, ok := m.services[generic.Subtype] | ||
| if !ok { | ||
| return nil, errors.New("no generic service") |
There was a problem hiding this comment.
this probably is not an error right? a component may not implement generic
There was a problem hiding this comment.
This is more about the generic subtype service missing, which should ALWAYS be there if a component model was ever registered (since it's unknown what specific models may or may not support generic, the service is just there as long as any component has been registered.) In theory this should be impossible to hit, but "abundance of caution" and all that.
If a component doesn't actually implement generic, then what will happen is the model itself will return "Unimplemented" if/when a generic (DoCommand) is actually tried on the resource or the service will error when trying to cast the resource. (This is effectively the same way things work in the main viam-server process.)
There was a problem hiding this comment.
Oh I see. Okay great then. Approving.
|
|
||
| if cfg.API.ResourceType == resource.ResourceTypeComponent && cfg.API != generic.Subtype { | ||
| genSvc, ok := m.services[generic.Subtype] | ||
| if !ok { |
edaniels
approved these changes
Jan 4, 2023
edaniels
changed the title
|
pretty excited about this! thanks james! |
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin. I somehow overlooked this case (generic interface on regular components) during the main modules project. Thanks to @dannenberg for pointing it out.