RSDK-1592 - opt rdk vue code to use new sdk wrappers #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edaniels
changed the title
viambot
added
safe to test
web/frontend/src/components/base.vue
Outdated
Comment on lines
128
to
131
| req.setName(props.name); | ||
| req.setLinear(linear); | ||
| req.setAngular(angular); | ||
|
|
||
| rcLogConditionally(req); |
There was a problem hiding this comment.
This is misleading - we are logging a request that never actually gets sent. We should add a hook to the SDK that allows clients to pass in a request logger.
viambot
added
safe to test
maximpertsov
force-pushed
the
update-sdk-wrappers
branch
from
8a692b4
to
d919f79
Compare
viambot
added
safe to test
Kschappacher
commented
Jan 19, 2023
web/frontend/package.json
Outdated
| @@ -8,7 +8,7 @@ | |||
| "@mdi/js": "^6.9.96", | |||
| "@viamrobotics/prime": "^0.0.106", | |||
| "@viamrobotics/rpc": "^0.1.32", | |||
| "@viamrobotics/sdk": "^0.0.11", | |||
| "@viamrobotics/sdk": "file:../../../viam-typescript-sdk/viamrobotics-sdk-0.0.13.tgz", | |||
There was a problem hiding this comment.
push an updated sdk with the log changes and swap this to the new version
Kschappacher
commented
Jan 19, 2023
web/frontend/src/components/base.vue
Outdated
| return await bc.spin(angle.value * (spinType.value === 'Clockwise' ? -1 : 1), spinSpeed.value); | ||
| } catch (error) { | ||
| displayError(error as ServiceError); | ||
| // eslint-disable-next-line no-useless-return |
There was a problem hiding this comment.
This lint check seems to be removing valid code. Do you think it is worth removing on the rdk as a whole?
There was a problem hiding this comment.
I actually think the linter is right. The first try/catch return is inside of an if block, so no further code is getting executed except for the second return, which does nothing. I would go one step further though and just remove all returns from this function as none of it is ever used:
const baseRun = async () => {
const bc = new BaseClient(props.client, props.name, { requestLogger: rcLogConditionally });
if (movementMode.value === 'Spin') {
try {
await bc.spin(angle.value * (spinType.value === 'Clockwise' ? -1 : 1), spinSpeed.value);
} catch (error) {
displayError(error as ServiceError);
}
} else if (movementMode.value === 'Straight') {
handleBaseStraight(props.name, {
movementType: movementType.value,
direction: direction.value === 'Forwards' ? 1 : -1,
speed: speed.value,
distance: increment.value,
});
}
};
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
maximpertsov
reviewed
Feb 1, 2023
micheal-parks
approved these changes
Feb 1, 2023
viambot
added
safe to test
|
Closed
randhid
pushed a commit
to randhid/rdk
that referenced
this pull request
Feb 25, 2023
Co-authored-by: Maxim Pertsov <maxim@viam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will opt the rdk remote control page to use the new typescript wrappers for the following components:
Base
Motor
Board
All wrappers have been successfully tested on a live robot running the updated rdk.