RSDK-1724 RSDK-1714 RSDK-1713: Camera RC fixes #1773
Conversation
viambot
added
the
safe to test
|
|
||
| const initStreamState = () => { | ||
| cameraStreamStates.set(props.cameraName, false); | ||
| }; | ||
|
|
||
| const clearStreamContainer = (camName: string) => { |
There was a problem hiding this comment.
Copied from app.vue. Not happy that it's just modifying the DOM.
There was a problem hiding this comment.
Agreed, looks fine for now but I'll make a ticket for removing all direct DOM manipulation from RDK.
viambot
added
safe to test
viambot
added
safe to test
| @@ -87,14 +87,6 @@ const connectedFirstTime = new Promise<void>((resolve) => { | |||
| connectedFirstTimeResolve = resolve; | |||
| }); | |||
|
|
|||
| const selectedMap = { | |||
There was a problem hiding this comment.
moved to camera.vue to avoid duplicating
| if (time === 'Manual Refresh') { | ||
| viewFrame(cameraName); | ||
| } else { | ||
| viewFrame(cameraName); |
There was a problem hiding this comment.
logic change here: the first frame is fetched immediately. this fixes a bug where it would take 30 sec (or however many you have selected) for the first frame to come in. this is often not apparent because we start in Live mode, but if one switches to "30 sec" interval, toggle the cam off, toggle the cam on, then the screen would be blank for 30 sec.
| resources: commonApi.ResourceName.AsObject[]; | ||
| client: Client; | ||
| } | ||
|
|
||
| interface Emits { | ||
| (event: 'download-raw-data'): void |
There was a problem hiding this comment.
removed unused emits
|
QAed by @Fahmina |
|
@micheal-parks I notice that I can edit the frequency drop down and type in the field. How can we fix that? Prime change? |
|
@nataliajacobowitz Yep, I'll make a ticket for that. |
Some issues fixed in this PR, many of which are related:
camrc2.mov
CC @mcvella
CC @nataliajacobowitz