RSDK-1729 - change resolution constraints to be of type IntExact #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rob1in
added
the
safe to test
viambot
removed
the
safe to test
Rob1in
added
the
safe to test
|
Rob1in
changed the title
| if attrs.Width > 0 { | ||
| constraint.Width = prop.IntExact(attrs.Width) | ||
| } else { | ||
| constraint.Width = prop.IntRanged{Min: 0, Ideal: 640, Max: 4096} |
There was a problem hiding this comment.
Why did the ideal width change from 800 to 640? Same question for height changing from 600 to 480.
There was a problem hiding this comment.
This is more aligned with the "default driver" (first) proposed by v4l for most webcams. Also, in the fitnessDistance algorithm of mediadevices, only min and max will matter.
There was a problem hiding this comment.
Mediadevices uses Ideal too in its fitnessDistance algorithm. It uses it when comparing one IntRanged to another (see IntRanged.Compare). The fitnessDistance method will compare IntRangeds (a type of IntConstraint) here.
All that being said I don't think it matters too much. This looks LGTM!
bazile-clyde
approved these changes
Jan 20, 2023
bhaney
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change resolutions constraints to be IntExact instead of IntRanged.