Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-859 add motion benchmarks to CI #1789

Merged
merged 68 commits into from
Jan 23, 2023
Merged

Conversation

raybjork
Copy link
Member

@raybjork raybjork commented Jan 19, 2023

This PR adds some new workflows to github actions that integrate with recent work done in the motion-testing library in the name of providing continuous testing for the motionplan package we have been developing in RDK. In summary, this workflow will fire on a pull request to main that changes files in one of the following packages, which are downstream of this pacakge:

  • motionplan
  • referenceframe
  • spatialmath

A separate action will fire upon completion that comments on the relevant PR with a readout of the test results.

For a demonstration of these actions, please see the associated PR which demonstrates that changing the number of solutions to seed from 50->1 is in fact worse for motion planning.

Also contingent on this PR being merged is another associated PR in motion-testing.

When this PR has approval, I will go back and merge in the PR to motion-testing, then change the associated branch references to "main" (which I will call out in comments) before finally merging into RDK.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 20, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2023
@raybjork raybjork merged commit 7d1be42 into main Jan 23, 2023
@raybjork raybjork deleted the DATA-859-motion-integration-tests branch January 23, 2023 16:32
randhid pushed a commit to randhid/rdk that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants