Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing capsule proto methods #1790

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Add missing capsule proto methods #1790

merged 1 commit into from
Jan 20, 2023

Conversation

biotinker
Copy link
Member

No description provided.

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Jan 20, 2023
spieswl
spieswl approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@spieswl spieswl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@github-actions
Copy link
Contributor

Code Coverage

Note: merge base coverage results not available, comparing against closest c86854a~1=(48ba3b2) instead

Package Line Rate Delta Health
go.viam.com/rdk/components/arm 56% 0.00% ➖
go.viam.com/rdk/components/arm/universalrobots 41% 0.00% ❌
go.viam.com/rdk/components/arm/xarm 2% 0.00% ❌
go.viam.com/rdk/components/arm/yahboom 7% 0.00% ❌
go.viam.com/rdk/components/audioinput 55% 0.00% ➖
go.viam.com/rdk/components/base 63% 0.00% ➖
go.viam.com/rdk/components/base/agilex 62% 0.00% ➖
go.viam.com/rdk/components/base/boat 41% 0.00% ❌
go.viam.com/rdk/components/base/wheeled 65% 0.00% ➖
go.viam.com/rdk/components/board 66% 0.00% ➖
go.viam.com/rdk/components/board/arduino 10% 0.00% ❌
go.viam.com/rdk/components/board/commonsysfs 48% 0.00% ❌
go.viam.com/rdk/components/board/fake 38% 0.00% ❌
go.viam.com/rdk/components/board/numato 19% 0.00% ❌
go.viam.com/rdk/components/board/pi 50% 0.00% ➖
go.viam.com/rdk/components/camera 63% -1.02% ➖
go.viam.com/rdk/components/camera/align 64% +0.52% ➖
go.viam.com/rdk/components/camera/fake 67% 0.00% ➖
go.viam.com/rdk/components/camera/ffmpeg 77% 0.00% ✅
go.viam.com/rdk/components/camera/transformpipeline 78% -0.28% ✅
go.viam.com/rdk/components/camera/videosource 45% +0.61% ❌
go.viam.com/rdk/components/encoder 4% 0.00% ❌
go.viam.com/rdk/components/encoder/fake 76% 0.00% ✅
go.viam.com/rdk/components/gantry 60% 0.00% ➖
go.viam.com/rdk/components/gantry/multiaxis 84% 0.00% ✅
go.viam.com/rdk/components/gantry/oneaxis 86% 0.00% ✅
go.viam.com/rdk/components/generic 83% 0.00% ✅
go.viam.com/rdk/components/gripper 68% 0.00% ➖
go.viam.com/rdk/components/input 87% 0.00% ✅
go.viam.com/rdk/components/input/gpio 84% 0.00% ✅
go.viam.com/rdk/components/motor 77% 0.00% ✅
go.viam.com/rdk/components/motor/dimensionengineering 63% 0.00% ➖
go.viam.com/rdk/components/motor/dmc4000 69% 0.00% ➖
go.viam.com/rdk/components/motor/fake 57% 0.00% ➖
go.viam.com/rdk/components/motor/gpio 64% +0.43% ➖
go.viam.com/rdk/components/motor/gpiostepper 57% 0.00% ➖
go.viam.com/rdk/components/motor/tmcstepper 62% 0.00% ➖
go.viam.com/rdk/components/movementsensor 75% 0.00% ✅
go.viam.com/rdk/components/movementsensor/cameramono 46% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsnmea 36% 0.00% ❌
go.viam.com/rdk/components/movementsensor/gpsrtk 28% 0.00% ❌
go.viam.com/rdk/components/posetracker 86% 0.00% ✅
go.viam.com/rdk/components/sensor 86% 0.00% ✅
go.viam.com/rdk/components/sensor/ultrasonic 25% 0.00% ❌
go.viam.com/rdk/components/servo 68% 0.00% ➖
go.viam.com/rdk/components/servo/gpio 71% 0.00% ✅
go.viam.com/rdk/config 76% 0.00% ✅
go.viam.com/rdk/control 57% 0.00% ➖
go.viam.com/rdk/data 79% 0.00% ✅
go.viam.com/rdk/examples/customresources/demos/complexmodule 0% 0.00% ❌
go.viam.com/rdk/examples/customresources/demos/remoteserver 0% 0.00% ❌
go.viam.com/rdk/grpc 25% 0.00% ❌
go.viam.com/rdk/ml 67% 0.00% ➖
go.viam.com/rdk/ml/inference 70% 0.00% ✅
go.viam.com/rdk/module 63% 0.00% ➖
go.viam.com/rdk/module/modmanager 79% 0.00% ✅
go.viam.com/rdk/motionplan 68% +8.80% ➖
go.viam.com/rdk/octree 98% 0.00% ✅
go.viam.com/rdk/operation 82% 0.00% ✅
go.viam.com/rdk/pointcloud 72% 0.00% ✅
go.viam.com/rdk/protoutils 59% 0.00% ➖
go.viam.com/rdk/referenceframe 71% 0.00% ✅
go.viam.com/rdk/registry 89% 0.00% ✅
go.viam.com/rdk/resource 84% 0.00% ✅
go.viam.com/rdk/rimage 78% 0.00% ✅
go.viam.com/rdk/rimage/depthadapter 94% 0.00% ✅
go.viam.com/rdk/rimage/transform 73% 0.00% ✅
go.viam.com/rdk/rimage/transform/cmd/extrinsic_calibration 67% 0.00% ➖
go.viam.com/rdk/robot 85% 0.00% ✅
go.viam.com/rdk/robot/client 81% 0.00% ✅
go.viam.com/rdk/robot/framesystem 65% 0.00% ➖
go.viam.com/rdk/robot/impl 80% 0.00% ✅
go.viam.com/rdk/robot/server 55% 0.00% ➖
go.viam.com/rdk/robot/web 62% 0.00% ➖
go.viam.com/rdk/robot/web/stream 87% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/armremotecontrol/builtin 52% 0.00% ➖
go.viam.com/rdk/services/baseremotecontrol 71% 0.00% ✅
go.viam.com/rdk/services/baseremotecontrol/builtin 79% 0.00% ✅
go.viam.com/rdk/services/datamanager 79% 0.00% ✅
go.viam.com/rdk/services/datamanager/builtin 78% -0.91% ✅
go.viam.com/rdk/services/datamanager/datacapture 70% 0.00% ✅
go.viam.com/rdk/services/datamanager/datasync 0% 0.00% ❌
go.viam.com/rdk/services/motion 63% 0.00% ➖
go.viam.com/rdk/services/motion/builtin 88% 0.00% ✅
go.viam.com/rdk/services/navigation 53% 0.00% ➖
go.viam.com/rdk/services/sensors 77% 0.00% ✅
go.viam.com/rdk/services/sensors/builtin 97% 0.00% ✅
go.viam.com/rdk/services/shell 14% 0.00% ❌
go.viam.com/rdk/services/slam 84% 0.00% ✅
go.viam.com/rdk/services/slam/builtin 70% +0.19% ✅
go.viam.com/rdk/services/vision 80% 0.00% ✅
go.viam.com/rdk/services/vision/builtin 74% 0.00% ✅
go.viam.com/rdk/session 97% 0.00% ✅
go.viam.com/rdk/spatialmath 82% -0.39% ✅
go.viam.com/rdk/subtype 92% 0.00% ✅
go.viam.com/rdk/utils 72% 0.00% ✅
go.viam.com/rdk/vision 26% 0.00% ❌
go.viam.com/rdk/vision/chess 80% 0.00% ✅
go.viam.com/rdk/vision/delaunay 87% 0.00% ✅
go.viam.com/rdk/vision/keypoints 92% 0.00% ✅
go.viam.com/rdk/vision/objectdetection 82% 0.00% ✅
go.viam.com/rdk/vision/odometry 60% 0.00% ➖
go.viam.com/rdk/vision/odometry/cmd 0% 0.00% ❌
go.viam.com/rdk/vision/segmentation 49% 0.00% ❌
go.viam.com/rdk/web/server 25% 0.00% ❌
Summary 65% (21349 / 32773) +0.52% ➖

@biotinker biotinker merged commit 5c672f7 into viamrobotics:main Jan 20, 2023
@bazile-clyde bazile-clyde mentioned this pull request Feb 7, 2023
Closed
randhid pushed a commit to randhid/rdk that referenced this pull request Feb 25, 2023
@biotinker @randhid
Add missing capsule proto methods (viamrobotics#1790)
6847d8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spieswl spieswl spieswl approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biotinker @spieswl @viambot