Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix meta.json schema test #4438

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix meta.json schema test #4438

merged 3 commits into from
Oct 10, 2024

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Oct 10, 2024 •
edited
Loading

What changed

  • use a virtualenv to unbreak the jsonschema test

Why

  • guessing ubuntu 22 -> 24 added 'don't break global python warning' but this is failing now on main

Passing test

✔️ https://github.com/viamrobotics/rdk/actions/runs/11276793733/job/31361443053

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 10, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 10, 2024
jckras
jckras approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jckras jckras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abe-winter abe-winter merged commit 7aa288f into main Oct 10, 2024
28 of 29 checks passed
@abe-winter abe-winter deleted the fix-meta-test branch October 10, 2024 15:53
jckras pushed a commit to jckras/rdk that referenced this pull request Oct 10, 2024
@abe-winter @jckras
fix meta.json schema test (viamrobotics#4438)
040438d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckras jckras jckras approved these changes

@cheukt cheukt cheukt approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abe-winter @cheukt @jckras @viambot