-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-8486] Fix 28byj-48 control issues #4442
[RSDK-8486] Fix 28byj-48 control issues #4442
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
@@ -268,7 +268,7 @@ func TestFunctions(t *testing.T) { | |||
err = m.GoFor(ctx, 146, 1, nil) | |||
test.That(t, err, test.ShouldBeNil) | |||
allObs = obs.All() | |||
latestLoggedEntry = allObs[len(allObs)-1] | |||
latestLoggedEntry = allObs[len(allObs)-2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what caused this to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a new logger line to tell the user that we're setting the rpm to max, not stopping, when we're passing in an rpm larger than the maxRPM, it was stopping because the logic previously called a stop when any warning was returned from CheckSpeed, not we only stop when an error is returned - the zero rpm error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now we check the entry before last to make sure it's the maxrpm warning that we expect.
Addressed in this PR:
Manual testing: