RSDK-9117 - Remove logger from NewModuleFromArgs, and moduleName from ModularMain

[cheukt]

we want to force a breakage so that users will not use the wrong logger when making a Go module.

logs now look like

10/23/2024, 3:23:27 PM error acme:component:gizmo/gizmo1 mygizmo/mygizmo.go:61 hello err from the other side log_ts 2024-10-23T19:23:27.697Z

on app

when it used to be

10/23/2024, 3:23:27 PM error {moduleName}.acme:component:gizmo/gizmo1 mygizmo/mygizmo.go:61 hello err from the other side log_ts 2024-10-23T19:23:27.697Z

I think it's generally fine to no longer have the moduleName tacked on to the beginning of the logger name.

this is a breaking change but all the user needs to do is to get rid of the logger/module name from their function calls

cc: @benjirewis

[randhid]

sighhhhhhhhh

[dgottlieb]

@cheukt I'm fine with leaving ModularMain alone. And just leaving a small comment about why it takes in a string that isn't used.

[randhid]

no it's okay, I'm being slightly melodramatic here. We will update the go modules eventually.

Will anything break the binaries currently uploaded to the registry? from my understanding, no.

[cheukt]

no, it will not break any current binaries, this will only break if you update rdk on the package

[cheukt]

we could also not break ModularMain, but we won't be using the moduleName parameter anymore. we could also further break NewLoggerFromArgs, but that seems unnecessary

[randhid]

we could also not break ModularMain, but we won't be using the moduleName parameter anymore.

I'm chaotic and okay with this.

break NewLoggerFromArgs, but that seems unnecessary

Is it used anywhere useful?

[cheukt]

NewLoggerFromArgs is not used anywhere useful in rdk, but the parameter is technically still used if you do call NewLoggerFromArgs, which is why I'm keeping it for now