-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-8965: add subclasses to module generation #4491
RSDK-8965: add subclasses to module generation #4491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few questions and some optional changes for readability but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing and we should figure out why the tests are failing, otherwise lgtm!
The tests failing doesn't seem to be related to this PR, as other PRs are also failing these two tests (Go 32-bit and Mac build) |
Jira Ticket
Add subclass parsing for the resources, namely board.
Flyby: reformatting some code
Testing done:
test-module-generation
workflow for the Python generationPython Example:
Go Example: