RSDK-9164 Configured services should not overwrite builtin services #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
can you add a test? rdk/robot/impl/robot_reconfigure_test.go Line 3284 in 752c9e8 |
|
This makes sense and is good with me but I want to add the disclaimer that I haven't thought through all the implications of this code and potential edge cases so will defer to @cheukt on this |
viambot
added
safe to test
|
@cheukt Added the requested test. While adding the test I noticed that the changes I made actually only allowed zero or one builtin services to be configured. I have also updated so N services may now be configured, and am testing accordingly. |
…builtin-motion-service
viambot
added
safe to test
raybjork
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a robot has components which depend upon the builtin motion service, and an additional motion service is configured, the builtin service breaks.
This PR allows configured motion services to coexist with the builtin service.
Tested by creating multiple motion services on a robot, and creating a module which depended upon all of them.