-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DATA-3338] fix-stability-of-vision-capture-all-from-camera-and-camera-get-images #4557
[DATA-3338] fix-stability-of-vision-capture-all-from-camera-and-camera-get-images #4557
Conversation
33c6fab
to
501209a
Compare
Co-authored-by: Sagie Maoz <sagiem@gmail.com>
Co-authored-by: Devin Hilly <devin.hilly@viam.com>
602c8aa
to
588a56e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work on this Nick 🎉🎉
Co-authored-by: Sagie Maoz <sagiem@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
// expectedUploadMetadata []*v1.UploadMetadata | ||
// expectedSensorData [][]*v1.SensorData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
partID := "my-part-id" | ||
|
||
now := time.Now() | ||
ts := data.Timestamps{TimeRequested: now, TimeReceived: time.Now()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should you use now
instead of calling time.Now()
for TimeReceived here? same for ts1
below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no b/c in general TimeRequested
happens before TimeReceived
. camera.GetImages is the only exception
Why:
Fixes:
Changes:
(ctx context.Context, _ map[string]*anypb.Any) (interface{}, error)
to(ctx context.Context, _ map[string]*anypb.Any) (data.CaptureResult, error)
see data/collector_types.go for more infodata.NewTabularCaptureResult
to create tabular capture results.