override nodejs to unbreak antique builds #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
Otterverse
approved these changes
Nov 26, 2024
|
was helpful to have your previous PR in the pi module repo, esp for the volume mounting trick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
/__e/node20/nodeto the container's node 16 intallationno-uploadbool to workflow_dispatch for the static build workflow (to support my testing today)Why
The actions nodejs install (
/__e/node20/node) now requires GLIBC 2_28 and we have 2_27; antique builds are failing as a result, example here. Context: the antique container intentionally links against old GLIBC for broad compatibility.Successful run
https://github.com/viamrobotics/rdk/actions/runs/12039219859