-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-9338: add optional parameters in data client #4595
Merged
purplenicole730
merged 7 commits into
viamrobotics:main
from
purplenicole730:RSDK-9338-add-optional-parameters
Dec 4, 2024
Merged
RSDK-9338: add optional parameters in data client #4595
purplenicole730
merged 7 commits into
viamrobotics:main
from
purplenicole730:RSDK-9338-add-optional-parameters
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Dec 3, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Dec 3, 2024
jckras
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a question about the Limit parameter for DataByFilter
functions otherwise LGTM! thanks for doing this nicole!
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Dec 3, 2024
vijayvuyyuru
pushed a commit
to vijayvuyyuru/rdk
that referenced
this pull request
Dec 4, 2024
vijayvuyyuru
pushed a commit
to vijayvuyyuru/rdk
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Note as to why I didn't put all optional parameters in structs:
At first, I thought I should be putting the optional
filter
parameters for some of the methods in its own<method>Options
struct. Thinking over it some more, I realized these functions could be seen as ones where the user is purposely leaving this parameternil
. This is in line with my discussions with Benji when we first introduced optional parameter structs. It also seemed more straightforward, especially with more clarifying comments.