RSDK-9326 - log important viam env variables #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
benjirewis
reviewed
Dec 4, 2024
viambot
added
safe to test
viambot
added
safe to test
good call, just tested and it looks really clean 👍 |
dgottlieb
reviewed
Dec 4, 2024
| @@ -57,6 +57,22 @@ type robotServer struct { | |||
| registry *logging.Registry | |||
| } | |||
|
|
|||
| func logViamEnvVariables(logger logging.Logger) { | |||
| var viamEnvVariables []interface{} | |||
There was a problem hiding this comment.
Let's also grab the home directory via PlatformHomeDir here.
(and looking at that function -- it should be using Go's stdlib os.UserHomeDir() because maybe windows one day -- not a required change for this PR)
viambot
added
safe to test
dgottlieb
approved these changes
Dec 4, 2024
cheukt
reviewed
Dec 4, 2024
web/server/entrypoint.go
Outdated
| @@ -99,6 +118,8 @@ func RunServer(ctx context.Context, args []string, _ logging.Logger) (err error) | |||
| return | |||
| } | |||
|
|
|||
| logViamEnvVariables(logger) | |||
There was a problem hiding this comment.
move this so that this gets logged to cloud as well
There was a problem hiding this comment.
good catch. moved it to after the remote logging is initialized
cheukt
reviewed
Dec 4, 2024
Co-authored-by: Cheuk <90270663+cheukt@users.noreply.github.com>
viambot
added
safe to test
…chappacher/rdk into RSDK-9326-viam-startup-env-logs
viambot
removed
the
safe to test
viambot
added
the
safe to test
cheukt
reviewed
Dec 5, 2024
web/server/entrypoint.go
Outdated
| @@ -164,6 +183,8 @@ func RunServer(ctx context.Context, args []string, _ logging.Logger) (err error) | |||
| logVersion(logger) | |||
| versionLogged = true | |||
|
|
|||
| logViamEnvVariables(logger) | |||
There was a problem hiding this comment.
can we put this in the logVersion method or slightly refactor the flow so that logViamEnvVariables is also tracked by the defer statement above? maybe change versionLogged to startupInfoLogged or something
viambot
added
safe to test
cheukt
approved these changes
Dec 5, 2024
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small pr to add logging of some viam env variables
Review Request