Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-6846: Adding the GetBillingConfig CLI endpoint #4607

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

RoxyFarhad
Copy link
Member

@RoxyFarhad RoxyFarhad commented Dec 6, 2024

The new command from the scope:

viam organization billing-service get-config --org-id=<org-id>

Manual Testing:
Screenshot 2024-12-06 at 2 16 01 PM

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 6, 2024
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks.

printf(cCtx.App.Writer, "City: %s", resp.BillingAddress.GetCity())
printf(cCtx.App.Writer, "State: %s", resp.BillingAddress.GetState())
printf(cCtx.App.Writer, "Postal Code: %s", resp.BillingAddress.GetZipcode())
printf(cCtx.App.Writer, "Country: %s", "USA")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 no international customers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha not yet

cli/client_test.go Outdated Show resolved Hide resolved
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 6, 2024
@JosephBorodach JosephBorodach self-requested a review December 6, 2024 18:26
Copy link

@JosephBorodach JosephBorodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we manually tested? If so LGTM :shipit:

@RoxyFarhad
Copy link
Member Author

have we manually tested? If so LGTM :shipit:

I actually forgot, and did catch a bug so thank you for calling that out :)

@RoxyFarhad RoxyFarhad merged commit 2a56096 into viamrobotics:main Dec 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants