Skip to content

Conversation

@hexbabe
Copy link
Member

@hexbabe hexbabe commented Oct 2, 2025

This PR deprecates RenderFrame and GetImage (logging deprecation warning) in camera/client.go and camera/server.go, deprecates format (fully removed), and replaces all usages throughout RDK. It also deletes GetImage from unit testing.

Manual Tests

linux/arm64

  • Test with config with multiple camera resources
  • Test rtsp with and without passthrough
  • Test ReadImage and GetImages collectors
  • Test CPU usage is on par with prev viam-servers
  • Test warning logs when GetImage is called

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base IsMoving
button Push
genericcomponent DoCommand
board GPIOPinByName
camera Properties
encoder Properties
motor IsMoving
sensor Readings
servo Position
arm EndPosition
audio MediaProperties
gantry Lengths
gripper IsMoving
input_controller Controls
movement_sensor LinearAcceleration
power_sensor Power
pose_tracker Poses
genericservice DoCommand
motion GetPose
vision GetProperties

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Oct 13, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 17, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 31, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Dec 31, 2025
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@hexbabe hexbabe marked this pull request as ready for review January 5, 2026 15:25
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@hexbabe hexbabe removed the request for review from oliviamiller January 5, 2026 15:36
@hexbabe
Copy link
Member Author

hexbabe commented Jan 5, 2026

removing Olivia bc she's sick

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 5, 2026
@hexbabe hexbabe merged commit 723361f into viamrobotics:main Jan 5, 2026
19 checks passed
@hexbabe hexbabe deleted the RSDK-11726 branch January 5, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test This pull request is marked safe to test from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants