RSDK-12450: Fix --cloud-config arg in reload command #5507
Merged
+76
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reload commands had a bug where it directly references
arg.PartIDinstead of partId variable. Earlier in the code path the partId variable is resolved from either --part-id or --cloud-config. Also added unit tests to ensure we don't break in the future.Found a similar issue with restart. Its a bit more of a edge case because I doubt anyone will restart with --cloud-config (in this case you would just kill the viam-server you have running locally), but felt like the consistency is nice.
Testing