Conversation
vic
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds support and demonstration for top-level contextual aspects in the default template. The changes update dependency versions and refactor the alice.nix example to showcase a context-aware aspect defined at the module's top level.
- Updates flake-aspects and den dependencies to versions that support top-level contextual aspects
- Refactors alice.nix to demonstrate the new top-level contextual aspect pattern with the
cooperaspect - Updates comments to clarify aspect inclusion patterns and usage
Reviewed Changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/examples/flake.lock | Updates den and flake-aspects dependencies to support top-level contextual aspects |
| templates/default/modules/aspects/alice.nix | Demonstrates top-level contextual aspect pattern by defining cooper aspect and refactoring includes |
| templates/default/flake.lock | Updates den and flake-aspects dependencies to support top-level contextual aspects |
| templates/bogus/flake.lock | Updates den and flake-aspects dependencies to support top-level contextual aspects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # from local bindings. | ||
| customEmacs | ||
| <eg/autologin> | ||
| # from the aspect tree, cooper example is defined bellow |
There was a problem hiding this comment.
Corrected spelling of 'bellow' to 'below'.
| # from the aspect tree, cooper example is defined bellow | |
| # from the aspect tree, cooper example is defined below |
|
|
||
| # Alice can include other aspects. | ||
| # For small, private one-shot aspects, use let-bindings like here. | ||
| # for more complex or re-usable ones, define on their own modules, |
There was a problem hiding this comment.
Grammatical error: 'define on' should be 'define in' or 'define them in'.
| # for more complex or re-usable ones, define on their own modules, | |
| # for more complex or re-usable ones, define in their own modules, |
update locks
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
See #91 for context.
See failure for reproduction
Support for top-level contextual aspects was added at vic/flake-aspects#14.
Closes #92.