Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables parametric (function-based) aspects to be defined directly at the top level of flake.aspects, rather than only through the __functor mechanism. This is achieved by changing the type constraint from aspectSubmodule to the more general providerType.
- Changed
aspectsTypeto useproviderTypeinstead ofaspectSubmodulefor freeform attributes - Updated test structure to wrap aspect definitions in a function receiving
{ aspects, ... } - Added a new test case demonstrating parametric top-level aspects
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/types.nix | Changed freeformType from aspectSubmodule to providerType to allow parametric aspects at top-level |
| checkmate.nix | Updated existing tests to use new aspect definition structure and added test for parametric top-level aspects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vic
added a commit
to vic/den
that referenced
this pull request
Nov 16, 2025
See #91 for context. See [failure](https://github.com/vic/bugs-den/actions/runs/19377336327/job/55448108522) for [reproduction](vic/bugs-den@f81dca6) Support for top-level contextual aspects was added at vic/flake-aspects#14. Closes #92.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See vic/den#92 for the issue this PR solves.