Split tests #19
Merged
Split tests #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the test suite by splitting a monolithic test file into individual test modules, improving test organization and maintainability. The changes reorganize the type system definitions and create separate test files for each test case.
- Simplified type definitions in
nix/types.nixby reusing theaspectsTypefor theprovidesoption - Split large test file into 14 individual test modules for better organization
- Created a new
checkmate/directory structure with dedicated flake and configuration
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| nix/types.nix | Simplified type definitions by reusing aspectsType and reordering type union |
| checkmate/modules/tests/without_flakes.nix | Extracted test for usage without flakes into separate module |
| checkmate/modules/tests/transpose_swap.nix | Extracted transpose swap test into separate module |
| checkmate/modules/tests/transpose_common.nix | Extracted transpose common childs test into separate module |
| checkmate/modules/tests/tranpose_flake_modules.nix | Extracted flake modules transpose test into separate module |
| checkmate/modules/tests/default_empty.nix | Extracted default empty test into separate module |
| checkmate/modules/tests/aspect_toplevel_parametric.nix | Extracted top-level parametric aspect test into separate module |
| checkmate/modules/tests/aspect_provides.nix | Extracted aspect provides test into separate module |
| checkmate/modules/tests/aspect_parametric.nix | Extracted parametric aspect test into separate module |
| checkmate/modules/tests/aspect_modules_resolved.nix | Extracted modules resolved test into separate module |
| checkmate/modules/tests/aspect_fixpoint.nix | Extracted fixpoint test into separate module |
| checkmate/modules/tests/aspect_dependencies.nix | Extracted aspect dependencies test into separate module |
| checkmate/modules/tests/aspect_default_provider_override.nix | Extracted default provider override test into separate module |
| checkmate/modules/tests/aspect_default_provider_functor.nix | Extracted default provider functor test into separate module |
| checkmate/modules/tests/aspect_chain.nix | Extracted aspect chain test into separate module |
| checkmate/modules/tests.nix | Refactored to provide shared test utilities and imports |
| checkmate/modules/checkmate.nix | New configuration module for checkmate test infrastructure |
| checkmate/flake.nix | New flake configuration for checkmate test suite |
| .github/workflows/test.yml | Updated workflow to checkout code and run tests from local directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,29 @@ | |||
| { | |||
There was a problem hiding this comment.
Corrected spelling of 'tranpose' to 'transpose' in filename.
| { transpose, ... }: | ||
| { | ||
|
|
||
| flake.tests."test transpose common childs become one parent" = { |
There was a problem hiding this comment.
Corrected spelling of 'childs' to 'children'.
Suggested change
| flake.tests."test transpose common childs become one parent" = { | |
| flake.tests."test transpose common children become one parent" = { |
| three-and-four-and-five = { | ||
| classOne.bar = [ "3" ]; | ||
| includes = [ | ||
| aspects.four |
There was a problem hiding this comment.
The test references aspects.four from the inner fixpoint context, but four is defined in the outer aspects.aspectTwo.provides scope. This should use top.aspects.aspectTwo.provides.four to match the actual scope, or the test may not validate the intended fixpoint behavior correctly.
Suggested change
| aspects.four | |
| top.aspects.aspectTwo.provides.four |
vic
force-pushed
the
split-tests
branch
3 times, most recently
from
2dc3431 to
be86657
Compare
Merged
vic
added a commit
that referenced
this pull request
Dec 17, 2025
vic
added a commit
that referenced
this pull request
Dec 17, 2025
vic
added a commit
that referenced
this pull request
Dec 18, 2025
* Revert "Split tests (#19)" This reverts commit 72ffc00. * update README with correct test commands (#22) * Revert "Revert "Split tests (#19)"" This reverts commit 1df56b4. * test merging aspects * fix: use custom merge functions for modules and resolve options (#23) When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions. --------- Co-authored-by: Albert O'Shea <albertoshea2@gmail.com>
vic
added a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.