fix: use custom merge functions for modules and resolve options #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions.
Owner
|
you are awesome! thanks so much |
vic
pushed a commit
that referenced
this pull request
Dec 18, 2025
When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions.
vic
added a commit
that referenced
this pull request
Dec 18, 2025
* Revert "Split tests (#19)" This reverts commit 72ffc00. * update README with correct test commands (#22) * Revert "Revert "Split tests (#19)"" This reverts commit 1df56b4. * test merging aspects * fix: use custom merge functions for modules and resolve options (#23) When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions. --------- Co-authored-by: Albert O'Shea <albertoshea2@gmail.com>
vic
pushed a commit
that referenced
this pull request
Dec 18, 2025
When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions.
vic
added a commit
that referenced
this pull request
Dec 18, 2025
* test merging aspects * fix: use custom merge functions for modules and resolve options (#23) When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config. The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions. * dont merge modules and resolve --------- Co-authored-by: Albert O'Shea <albertoshea2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging aspect configs across scopes (e.g. bar = config.foo), the modules and resolve options were incorrectly merging pre-computed values from individual scopes instead of recomputing from the merged config.
The fix uses custom type merge functions that always recompute from the final merged config, ensuring resolved modules reflect all merged aspect definitions.